Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp

Issue 1774943003: blink: Rename platform/ methods to prefix with get when they collide. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: clash-platform: rebase-yayyyyyyyy Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp
diff --git a/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp b/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp
index 9a07d629d4953f98720c52605af47164c1aa934e..91d75aafc0bbadda2d87c49bfe7639e25c36c842 100644
--- a/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp
+++ b/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp
@@ -129,9 +129,9 @@ TEST(ImageResourceTest, MultipartImage)
ASSERT_FALSE(cachedImage->resourceBuffer());
ASSERT_FALSE(cachedImage->errorOccurred());
ASSERT_TRUE(cachedImage->hasImage());
- ASSERT_FALSE(cachedImage->image()->isNull());
- ASSERT_EQ(cachedImage->image()->width(), 1);
- ASSERT_EQ(cachedImage->image()->height(), 1);
+ ASSERT_FALSE(cachedImage->getImage()->isNull());
+ ASSERT_EQ(cachedImage->getImage()->width(), 1);
+ ASSERT_EQ(cachedImage->getImage()->height(), 1);
ASSERT_EQ(client.imageChangedCount(), 1);
ASSERT_TRUE(client.notifyFinishedCalled());
}
@@ -182,21 +182,21 @@ TEST(ImageResourceTest, DecodedDataRemainsWhileHasClients)
cachedImage->finish();
ASSERT_FALSE(cachedImage->errorOccurred());
ASSERT_TRUE(cachedImage->hasImage());
- ASSERT_FALSE(cachedImage->image()->isNull());
+ ASSERT_FALSE(cachedImage->getImage()->isNull());
ASSERT_TRUE(client.notifyFinishedCalled());
// The prune comes when the ImageResource still has clients. The image should not be deleted.
cachedImage->prune();
ASSERT_TRUE(cachedImage->hasClients());
ASSERT_TRUE(cachedImage->hasImage());
- ASSERT_FALSE(cachedImage->image()->isNull());
+ ASSERT_FALSE(cachedImage->getImage()->isNull());
// The ImageResource no longer has clients. The image should be deleted by prune.
client.removeAsClient();
cachedImage->prune();
ASSERT_FALSE(cachedImage->hasClients());
ASSERT_FALSE(cachedImage->hasImage());
- ASSERT_TRUE(cachedImage->image()->isNull());
+ ASSERT_TRUE(cachedImage->getImage()->isNull());
}
TEST(ImageResourceTest, UpdateBitmapImages)
@@ -213,10 +213,10 @@ TEST(ImageResourceTest, UpdateBitmapImages)
cachedImage->finish();
ASSERT_FALSE(cachedImage->errorOccurred());
ASSERT_TRUE(cachedImage->hasImage());
- ASSERT_FALSE(cachedImage->image()->isNull());
+ ASSERT_FALSE(cachedImage->getImage()->isNull());
ASSERT_EQ(client.imageChangedCount(), 2);
ASSERT_TRUE(client.notifyFinishedCalled());
- ASSERT_TRUE(cachedImage->image()->isBitmapImage());
+ ASSERT_TRUE(cachedImage->getImage()->isBitmapImage());
}
TEST(ImageResourceTest, ReloadIfLoFi)
@@ -239,10 +239,10 @@ TEST(ImageResourceTest, ReloadIfLoFi)
cachedImage->finish();
ASSERT_FALSE(cachedImage->errorOccurred());
ASSERT_TRUE(cachedImage->hasImage());
- ASSERT_FALSE(cachedImage->image()->isNull());
+ ASSERT_FALSE(cachedImage->getImage()->isNull());
ASSERT_EQ(client.imageChangedCount(), 2);
ASSERT_TRUE(client.notifyFinishedCalled());
- ASSERT_TRUE(cachedImage->image()->isBitmapImage());
+ ASSERT_TRUE(cachedImage->getImage()->isBitmapImage());
cachedImage->reloadIfLoFi(fetcher);
ASSERT_FALSE(cachedImage->errorOccurred());
@@ -255,9 +255,9 @@ TEST(ImageResourceTest, ReloadIfLoFi)
cachedImage->finish();
ASSERT_FALSE(cachedImage->errorOccurred());
ASSERT_TRUE(cachedImage->hasImage());
- ASSERT_FALSE(cachedImage->image()->isNull());
+ ASSERT_FALSE(cachedImage->getImage()->isNull());
ASSERT_TRUE(client.notifyFinishedCalled());
- ASSERT_TRUE(cachedImage->image()->isBitmapImage());
+ ASSERT_TRUE(cachedImage->getImage()->isBitmapImage());
}
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/fetch/ImageResource.cpp ('k') | third_party/WebKit/Source/core/frame/FrameSerializer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698