Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1774943002: Install the internalized string as flattened version into cons-strings for fast re-internalization. (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Install the internalized string as flattened version into cons-strings for fast re-internalization. BUG= Committed: https://crrev.com/1b096975810cd39687d1a1655cbb54ce27d40cb1 Cr-Commit-Position: refs/heads/master@{#34585}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M src/objects.cc View 1 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 9 months ago (2016-03-08 12:12:54 UTC) #2
Jakob Kummerow
lgtm
4 years, 9 months ago (2016-03-08 13:17:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774943002/20001
4 years, 9 months ago (2016-03-08 13:20:01 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-08 13:39:36 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 13:39:53 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1b096975810cd39687d1a1655cbb54ce27d40cb1
Cr-Commit-Position: refs/heads/master@{#34585}

Powered by Google App Engine
This is Rietveld 408576698