Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1774913006: Add error codes to server protocol (#25958). (Closed)

Created:
4 years, 9 months ago by pquitslund
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -7 lines) Patch
M pkg/analysis_server/doc/api.html View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/plugin/protocol/generated_protocol.dart View 8 chunks +28 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/protocol_server.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/analysis_server/test/protocol_server_test.dart View 3 chunks +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/generated/java/types/AnalysisError.java View 8 chunks +21 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +6 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
pquitslund
4 years, 9 months ago (2016-03-09 00:49:56 UTC) #2
Brian Wilkerson
LGTM, but we should follow up by capturing the error code in the engine's representation ...
4 years, 9 months ago (2016-03-09 01:15:01 UTC) #3
pquitslund
Thank you! https://codereview.chromium.org/1774913006/diff/1/pkg/analysis_server/tool/spec/spec_input.html File pkg/analysis_server/tool/spec/spec_input.html (right): https://codereview.chromium.org/1774913006/diff/1/pkg/analysis_server/tool/spec/spec_input.html#newcode9 pkg/analysis_server/tool/spec/spec_input.html:9: <h1 style="color:#999999">Version <version>1.14.0</version></h1> On 2016/03/09 01:15:01, Brian ...
4 years, 9 months ago (2016-03-09 18:42:45 UTC) #4
pquitslund
4 years, 9 months ago (2016-03-09 18:44:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e7e205f00b24faf9ee5cdf0baf21b8a0a04f8c3a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698