Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 1774913005: Create new buffer (if necessary) on vkMap (Closed)

Created:
4 years, 9 months ago by jvanverth1
Modified:
4 years, 9 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Create new buffer (if necessary) on vkMap The assumption here is that we only read via a Map after we sync the command buffer, and that when writing we don't Map to update, but to overwrite. This appears to be true. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1774913005 Committed: https://skia.googlesource.com/skia/+/dbb429a1b2586edc45b06609c3526d75fb565933

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M src/gpu/vk/GrVkBuffer.cpp View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
jvanverth1
4 years, 9 months ago (2016-03-08 21:03:26 UTC) #4
egdaniel
lgtm
4 years, 9 months ago (2016-03-16 13:05:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774913005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774913005/1
4 years, 9 months ago (2016-03-16 13:21:23 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 13:47:42 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/dbb429a1b2586edc45b06609c3526d75fb565933

Powered by Google App Engine
This is Rietveld 408576698