Firing got/lost pointer capture events

third_party/WebKit/Source/core/events/PointerEventFactory.cpp

Index: third_party/WebKit/Source/core/events/PointerEventFactory.cpp
diff --git a/third_party/WebKit/Source/core/events/PointerEventFactory.cpp b/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
index 3c7ef36f4a75d2f1884e87c3a45fcf1e28d8c824..2a1f23e5e89e3ed42a1c13e17b474236eff2190d 100644
--- a/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
+++ b/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
@@ -179,11 +179,33 @@ PassRefPtrWillBeRawPtr<PointerEvent> PointerEventFactory::createPointerCancel(co
     return PointerEvent::create(EventTypeNames::pointercancel, pointerEventInit);
 }
 
-PassRefPtrWillBeRawPtr<PointerEvent> PointerEventFactory::create(
+PassRefPtrWillBeRawPtr<PointerEvent> PointerEventFactory::createPointerCapture(
+    PassRefPtrWillBeRawPtr<PointerEvent> pointerEvent,

[sof, 2016/03/08 18:31:06]

This is yet another instance where you _have to_ bind the PassRefPtr<> to a
local before using it multiple times in the method.

You may want to carefully look over the non-Oilpan failures that
PointerEventFactory CLs have caused over the past couple of weeks and try to
avoid repeating those. One way to be sure you're doing it right is to exercise
the tryserver.blink:link_blink_oilpan_rel trybot. Don't be tricked by the
"oilpan" in its name, it is configured to build with Oilpan off.

[Navid Zolghadr, 2016/03/08 18:34:14]

I was paying attention not to add any more incorrect code. But I wasn't actively
fixing the existing code. I'll take another look over PointerEvent classes and
try to fix all the existing instances in this CL.

[Navid Zolghadr, 2016/03/08 21:50:25]

I tried running tryserver.blink:link_blink_oilpan_rel and it seems to pass. Were
you expecting to fail since I have this incorrect pointertype? Or should I look
in the stdio of that bot and look for some specific things? In that case what
that thing would be?

+    const AtomicString& type)
+{
+    ASSERT(type == EventTypeNames::gotpointercapture
+        || type == EventTypeNames::lostpointercapture);
+
+    PointerEventInit pointerEventInit;
+    pointerEventInit.setPointerId(pointerEvent->pointerId());
+    pointerEventInit.setPointerType(pointerEvent->pointerType());
+    pointerEventInit.setIsPrimary(pointerEvent->isPrimary());
+    pointerEventInit.setBubbles(true);
+    pointerEventInit.setCancelable(false);
+
+    return PointerEvent::create(type, pointerEventInit);
+}
+
+PassRefPtrWillBeRawPtr<PointerEvent> PointerEventFactory::createPointerTransition(
     PassRefPtrWillBeRawPtr<PointerEvent> pointerEvent,
     const AtomicString& type,
     PassRefPtrWillBeRawPtr<EventTarget> relatedTarget)
 {
+    ASSERT(type == EventTypeNames::pointerout
+        || type == EventTypeNames::pointerleave
+        || type == EventTypeNames::pointerover
+        || type == EventTypeNames::pointerenter);
+
     PointerEventInit pointerEventInit;
 
     pointerEventInit.setPointerId(pointerEvent->pointerId());