Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1293)

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 1774913003: (Re-commit) Fix SVGDocument return title that is not a child of the root element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Document.cpp
diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp
index 93a13ab219b2a1740691546634dd51c213453042..7bc17c492f0cfabffb3e6c3f6a5beed29655b1d0 100644
--- a/third_party/WebKit/Source/core/dom/Document.cpp
+++ b/third_party/WebKit/Source/core/dom/Document.cpp
@@ -1287,33 +1287,51 @@ void Document::updateTitle(const String& title)
void Document::setTitle(const String& title)
{
// Title set by JavaScript -- overrides any title elements.
- if (!isHTMLDocument() && !isXHTMLDocument()) {
- m_titleElement = nullptr;
- } else if (!m_titleElement) {
- HTMLElement* headElement = head();
- if (!headElement)
- return;
- m_titleElement = HTMLTitleElement::create(*this);
- headElement->appendChild(m_titleElement.get());
+ if (!m_titleElement) {
+ if (isHTMLDocument() || isXHTMLDocument()) {
+ HTMLElement* headElement = head();
+ if (!headElement)
+ return;
+ m_titleElement = HTMLTitleElement::create(*this);
+ headElement->appendChild(m_titleElement.get());
+ } else if (isSVGDocument()) {
+ Element* element = documentElement();
+ if (!isSVGSVGElement(element))
+ return;
+ m_titleElement = SVGTitleElement::create(*this);
+ element->insertBefore(m_titleElement.get(), element->firstChild());
+ }
+ } else {
+ if (!isHTMLDocument() && !isXHTMLDocument() && !isSVGDocument())
+ m_titleElement = nullptr;
}
if (isHTMLTitleElement(m_titleElement))
toHTMLTitleElement(m_titleElement)->setText(title);
+ else if (isSVGTitleElement(m_titleElement))
+ toSVGTitleElement(m_titleElement)->setText(title);
else
updateTitle(title);
}
void Document::setTitleElement(Element* titleElement)
{
- // Only allow the first title element to change the title -- others have no effect.
- if (m_titleElement && m_titleElement != titleElement) {
- if (isHTMLDocument() || isXHTMLDocument()) {
+ // If the root element is an svg element in the SVG namespace, then let value be the child text content
+ // of the first title element in the SVG namespace that is a child of the root element.
+ if (isSVGSVGElement(documentElement())) {
+ m_titleElement = Traversal<SVGTitleElement>::firstChild(*documentElement());
+ } else {
+ if (m_titleElement && m_titleElement != titleElement)
m_titleElement = Traversal<HTMLTitleElement>::firstWithin(*this);
- } else if (isSVGDocument()) {
- m_titleElement = Traversal<SVGTitleElement>::firstWithin(*this);
+ else
+ m_titleElement = titleElement;
+
+ // If the root element isn't an svg element in the SVG namespace and the title element is
+ // in the SVG namespace, it is ignored.
+ if (isSVGTitleElement(m_titleElement)) {
+ m_titleElement = nullptr;
+ return;
}
- } else {
- m_titleElement = titleElement;
}
if (isHTMLTitleElement(m_titleElement))

Powered by Google App Engine
This is Rietveld 408576698