third_party/WebKit/LayoutTests/svg/dom/file-extension-svg-and-inner-svg-document.svg - Issue 1774913003: (Re-commit) Fix SVGDocument return title that is not a child of the root element

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/dom/file-extension-svg-and-inner-svg-document.svg

Issue 1774913003: (Re-commit) Fix SVGDocument return title that is not a child of the root element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/imported/web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-09-expected.txt ('k') | third_party/WebKit/LayoutTests/svg/dom/file-extension-svg-and-inner-svg-document-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html xmlns="http://www.w3.org/1999/xhtml" xlink="http://www.w3.org/1999/xlink">
	fs 2016/03/08 17:05:26 xlink="..." is not useful for anything (to declare xlink="..." is not useful for anything (to declare/open the xlink NS you'd do xmlns:xlink="...", but you don't use the xlink NS in any way here, so just drop this and the same thing below.) hyunjunekim2 2016/03/09 15:54:46 Done. Remove this test. Show quoted text On 2016/03/08 17:05:26, fs wrote: > xlink="..." is not useful for anything (to declare/open the xlink NS you'd do > xmlns:xlink="...", but you don't use the xlink NS in any way here, so just drop > this and the same thing below.) Done. Remove this test.
	2 <head>

	3 <script src="../../resources/js-test.js"></script>
	fs 2016/03/08 17:05:26 Use testharness.js instead (there no need to invol Use testharness.js instead (there no need to involve the testRunner in this test.) hyunjunekim2 2016/03/09 15:54:46 Done. Show quoted text On 2016/03/08 17:05:26, fs wrote: > Use testharness.js instead (there no need to involve the testRunner in this > test.) Done.
	4 </head>

	5 <body id="bodyElement">

	6 <svg xmlns="http://www.w3.org/2000/svg" id="svgElement" xlink="http://www.w3 .org/1999/xlink">

	7 <g id="gElement"></g>

	8 </svg>

	9 </body>

	10 <script>

	11 if (window.testRunner) {

	12 testRunner.dumpAsText();

	13 testRunner.waitUntilDone();
	fs 2016/03/08 17:05:26 You don't need waitUntilDone in this case, because You don't need waitUntilDone in this case, because your calling notifyDone within the same script-execution. And the test completes before onload. hyunjunekim2 2016/03/09 15:54:46 Done. Remove this test. Show quoted text On 2016/03/08 17:05:26, fs wrote: > You don't need waitUntilDone in this case, because your calling notifyDone > within the same script-execution. And the test completes before onload. Done. Remove this test.
	14 }

	15

	16 var g = document.getElementById("gElement");

	17 var svgElement = document.getElementById("svgElement");

	18 title1 = document.createElementNS("http://www.w3.org/1999/xhtml", "title");

	19 title1.textContent = "title1";

	20 g.appendChild(title1);

	21 shouldBeEqualToString('document.title','');

	22 title2 = document.createElementNS("http://www.w3.org/1999/xhtml", "title");

	23 title2.textContext = "title2";

	24 svgElement.appendChild(title2);

	25 shouldBeEqualToString('document.title','');

	26

	27 if (window.testRunner)

	28 testRunner.notifyDone();

	29 </script>

	30 </html>

OLD	NEW