third_party/WebKit/LayoutTests/svg/dom/set-title-element-on-inner-svg-document.html - Issue 1774913003: (Re-commit) Fix SVGDocument return title that is not a child of the root element

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/dom/set-title-element-on-inner-svg-document.html

Issue 1774913003: (Re-commit) Fix SVGDocument return title that is not a child of the root element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/imported/web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-09-expected.txt ('k') | third_party/WebKit/LayoutTests/svg/dom/svg-document-set-title-mutations.html » ('j') | third_party/WebKit/Source/core/dom/Document.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <script>

	5 test(function() {

	6 var doc = document.implementation.createDocument("http://www.w3.org/2000/svg", "SVG", null);

	7 var body = doc.createElementNS("http://www.w3.org/1999/xhtml", "body");

	8 doc.documentElement.appendChild(body);

	9 var svgDoc = doc.implementation.createDocument("http://www.w3.org/2000/svg", " svg", null);
	fs 2016/03/09 16:06:48 You don't need to create another document (to just You don't need to create another document (to just transplant its doc-root). Just doc.createElementNS(...) should be enough. hyunjunekim2 2016/03/10 15:00:44 Done. Show quoted text On 2016/03/09 16:06:48, fs wrote: > You don't need to create another document (to just transplant its doc-root). > Just doc.createElementNS(...) should be enough. Done.
	10 var svgElement = svgDoc.documentElement;

	11 var g = svgDoc.createElementNS("http://www.w3.org/2000/svg", "g");

	12 svgElement.appendChild(g);

	13 body.appendChild(svgDoc.documentElement);

	14 var title1 = doc.createElementNS("http://www.w3.org/1999/xhtml", "title");

	15 title1.textContext = "title1";

	16 g.appendChild(title1);

	17 assert_equals(doc.title,'');

	18 var title2 = doc.createElementNS("http://www.w3.org/1999/xhtml", "title");

	19 title2.textContext = "title2";

	20 svgElement.appendChild(title2);

	21 assert_equals(doc.title,'');

	22 }, "Test for setting title element of inner svg document.");

	23 </script>

OLD	NEW