Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2075)

Unified Diff: chrome/renderer/page_load_histograms.h

Issue 1774873002: Remove incorrect PLT.PT.NavigationStartToFirstLayout histogram (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: jochen comment Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/page_load_histograms.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/page_load_histograms.h
diff --git a/chrome/renderer/page_load_histograms.h b/chrome/renderer/page_load_histograms.h
index 4778a8a0b68015923ad7df9b6e1bd3cbe9794f69..369965593f14c00d1faf3ca633ce22117f65424f 100644
--- a/chrome/renderer/page_load_histograms.h
+++ b/chrome/renderer/page_load_histograms.h
@@ -6,7 +6,6 @@
#define CHROME_RENDERER_PAGE_LOAD_HISTOGRAMS_H_
#include "base/macros.h"
-#include "base/memory/weak_ptr.h"
#include "content/public/renderer/render_view_observer.h"
namespace blink {
@@ -26,7 +25,6 @@ class PageLoadHistograms : public content::RenderViewObserver {
// RenderViewObserver implementation.
void FrameWillClose(blink::WebFrame* frame) override;
void ClosePage() override;
- void DidUpdateLayout() override;
// Dump all page load histograms appropriate for the given frame.
//
@@ -49,14 +47,9 @@ class PageLoadHistograms : public content::RenderViewObserver {
// so first_paint and first_paint_after_load can be 0.
void Dump(blink::WebFrame* frame);
- bool ShouldDump(blink::WebFrame* frame);
- void MaybeDumpFirstLayoutHistograms();
void LogPageLoadTime(const content::DocumentState* load_times,
const blink::WebDataSource* ds) const;
- bool dumped_first_layout_histograms_;
- base::WeakPtrFactory<PageLoadHistograms> weak_factory_;
-
DISALLOW_COPY_AND_ASSIGN(PageLoadHistograms);
};
« no previous file with comments | « no previous file | chrome/renderer/page_load_histograms.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698