Remove incorrect PLT.PT.NavigationStartToFirstLayout histogram

chrome/renderer/page_load_histograms.h

Index: chrome/renderer/page_load_histograms.h
diff --git a/chrome/renderer/page_load_histograms.h b/chrome/renderer/page_load_histograms.h
index 4778a8a0b68015923ad7df9b6e1bd3cbe9794f69..8d0dd3a303c2d1bfe32b1a670ffb22ac62362673 100644
--- a/chrome/renderer/page_load_histograms.h
+++ b/chrome/renderer/page_load_histograms.h
@@ -6,7 +6,6 @@
 #define CHROME_RENDERER_PAGE_LOAD_HISTOGRAMS_H_
 
 #include "base/macros.h"
-#include "base/memory/weak_ptr.h"
 #include "content/public/renderer/render_view_observer.h"
 
 namespace blink {
@@ -20,13 +19,11 @@ class DocumentState;
 class PageLoadHistograms : public content::RenderViewObserver {
  public:
   explicit PageLoadHistograms(content::RenderView* render_view);
-  ~PageLoadHistograms() override;

[jochen (gone - plz use gerrit), 2016/03/09 15:07:26]

why?

[Bryan McQuade, 2016/03/09 20:29:49]

The destructor was added as part of the CL
https://codereview.chromium.org/1230513002 that's being reverted.

IIRC an explicit empty destructor was needed because of the WeakPtrFactory,
which was also introduced in that change.

 
  private:
   // RenderViewObserver implementation.
   void FrameWillClose(blink::WebFrame* frame) override;
   void ClosePage() override;
-  void DidUpdateLayout() override;
 
   // Dump all page load histograms appropriate for the given frame.
   //
@@ -49,14 +46,9 @@ class PageLoadHistograms : public content::RenderViewObserver {
   // so first_paint and first_paint_after_load can be 0.
   void Dump(blink::WebFrame* frame);
 
-  bool ShouldDump(blink::WebFrame* frame);
-  void MaybeDumpFirstLayoutHistograms();
   void LogPageLoadTime(const content::DocumentState* load_times,
                        const blink::WebDataSource* ds) const;
 
-  bool dumped_first_layout_histograms_;
-  base::WeakPtrFactory<PageLoadHistograms> weak_factory_;
-
   DISALLOW_COPY_AND_ASSIGN(PageLoadHistograms);
 };