sdk/lib/_internal/lib/mirrors_patch.dart - Issue 177483002: Add validation of private symbols to the dart2js mirrors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/lib/mirrors_patch.dart

Issue 177483002: Add validation of private symbols to the dart2js mirrors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/lib/mirrors_patch.dart

diff --git a/sdk/lib/_internal/lib/mirrors_patch.dart b/sdk/lib/_internal/lib/mirrors_patch.dart

index 71c1e68c7b55a3538910eddf6f628846c16b738d..5d4a5fa492f645fd536e9744da234b75ec944efc 100644

--- a/sdk/lib/_internal/lib/mirrors_patch.dart

+++ b/sdk/lib/_internal/lib/mirrors_patch.dart

@@ -10,7 +10,7 @@ patch class MirrorSystem {

patch static String getName(Symbol symbol) => js.getName(symbol);

patch static Symbol getSymbol(String name, [LibraryMirror library]) {

- throw new UnimplementedError("MirrorSystem.getSymbol not implemented");

+ return js.getSymbol(name, library);

}

« no previous file with comments | « sdk/lib/_internal/lib/js_mirrors.dart ('k') | sdk/lib/internal/symbol.dart » ('j') | no next file with comments »