Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1774733002:
Update net triage instructions. (Closed)
|
Created:
4 years, 9 months ago by mmenke Modified:
4 years, 9 months ago Reviewers:
Randy Smith (Not in Mondays) CC:
chromium-reviews, cbentzel+watch_chromium.org, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, Justin Novosad, dglazkov+blink, Rik, blink-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate net triage docs.
In particular, rework triage instructions, and clean up
net-internals doc a little.
NOTRY=true
BUG=none
Committed: https://crrev.com/212fe432b87a4ee2aaaff40a55239b4740eb09e5
Cr-Commit-Position: refs/heads/master@{#380421}
Patch Set 1 #Patch Set 2 : Fixes #
Total comments: 10
Patch Set 3 : Response to comments #Patch Set 4 : sort #
Messages
Total messages: 20 (12 generated)
Description was changed from ========== Update net triage instructions. BUG=none ========== to ========== Update net docs. In particular, rework triage instructions, and cleanup net-internals doc a little. BUG=none ==========
Patchset #2 (id:20001) has been deleted
Patchset #1 (id:1) has been deleted
mmenke@chromium.org changed reviewers: + rdsmith@chromium.org
Randy: WDYT? I've tried to de-emphasize crashes, and put more emphasis on keeping the ball rolling on user-reported bugs (With the exception of those empty bugs with a crash ID).
Description was changed from ========== Update net docs. In particular, rework triage instructions, and cleanup net-internals doc a little. BUG=none ========== to ========== Update net docs. In particular, rework triage instructions, and clean up net-internals doc a little. BUG=none ==========
LGTM (if you disagree with notes below, feel free to follow your own judgement). I'll note that this is generally moving information from the suggested workflow into the responsibilities section; I tried to evaluate whether that movement was appropriate in all cases and didn't spot any in which it wasn't, but it's a bit of a shift in framing. Not one I object to, but I wanted to call out that it was happening. https://codereview.chromium.org/1774733002/diff/60001/net/docs/bug-triage.md File net/docs/bug-triage.md (right): https://codereview.chromium.org/1774733002/diff/60001/net/docs/bug-triage.md#... net/docs/bug-triage.md:9: ### Required: Worthwhile indicating that this is in some approximation of priority order, or just leave that implicit? https://codereview.chromium.org/1774733002/diff/60001/net/docs/bug-triage.md#... net/docs/bug-triage.md:63: Due of the way the bug report wizard works, a lot of bugs incorrectly end nit: "Note that Due of" -> "Note that due to"? https://codereview.chromium.org/1774733002/diff/60001/net/docs/bug-triage.md#... net/docs/bug-triage.md:79: as it belongs to component more specific than Cr-Internals-Network. "as long as" -> "until"? https://codereview.chromium.org/1774733002/diff/60001/net/docs/bug-triage.md#... net/docs/bug-triage.md:111: that once it has at least a day of date. Recent releases available nit: "data". https://codereview.chromium.org/1774733002/diff/60001/net/docs/bug-triage.md#... net/docs/bug-triage.md:116: than two users should be investigated. nit: Remove "should be investigated".
Thanks for the feedback, I'll update this tomorrow. On 2016/03/09 21:39:09, Randy Smith - Not in Fridays wrote: > LGTM (if you disagree with notes below, feel free to follow your own judgement). > > > I'll note that this is generally moving information from the suggested workflow > into the responsibilities section; I tried to evaluate whether that movement was > appropriate in all cases and didn't spot any in which it wasn't, but it's a bit > of a shift in framing. Not one I object to, but I wanted to call out that it > was happening. This is certainly true. I feel that the moved "suggested workflow" things could be more accurately described as "expected tasks", so tried to move things around to fix that, and plan to draw attention to it when I announce the changes. > https://codereview.chromium.org/1774733002/diff/60001/net/docs/bug-triage.md > File net/docs/bug-triage.md (right): > > https://codereview.chromium.org/1774733002/diff/60001/net/docs/bug-triage.md#... > net/docs/bug-triage.md:9: ### Required: > Worthwhile indicating that this is in some approximation of priority order, or > just leave that implicit? > > https://codereview.chromium.org/1774733002/diff/60001/net/docs/bug-triage.md#... > net/docs/bug-triage.md:63: Due of the way the bug report wizard works, a lot of > bugs incorrectly end > nit: "Note that Due of" -> "Note that due to"? > > https://codereview.chromium.org/1774733002/diff/60001/net/docs/bug-triage.md#... > net/docs/bug-triage.md:79: as it belongs to component more specific than > Cr-Internals-Network. > "as long as" -> "until"? > > https://codereview.chromium.org/1774733002/diff/60001/net/docs/bug-triage.md#... > net/docs/bug-triage.md:111: that once it has at least a day of date. Recent > releases available > nit: "data". > > https://codereview.chromium.org/1774733002/diff/60001/net/docs/bug-triage.md#... > net/docs/bug-triage.md:116: than two users should be investigated. > nit: Remove "should be investigated".
https://codereview.chromium.org/1774733002/diff/60001/net/docs/bug-triage.md File net/docs/bug-triage.md (right): https://codereview.chromium.org/1774733002/diff/60001/net/docs/bug-triage.md#... net/docs/bug-triage.md:9: ### Required: On 2016/03/09 21:39:09, Randy Smith - Not in Fridays wrote: > Worthwhile indicating that this is in some approximation of priority order, or > just leave that implicit? Good idea, done. Also moved UMA up to the second in the list. https://codereview.chromium.org/1774733002/diff/60001/net/docs/bug-triage.md#... net/docs/bug-triage.md:63: Due of the way the bug report wizard works, a lot of bugs incorrectly end On 2016/03/09 21:39:09, Randy Smith - Not in Fridays wrote: > nit: "Note that Due of" -> "Note that due to"? Done. https://codereview.chromium.org/1774733002/diff/60001/net/docs/bug-triage.md#... net/docs/bug-triage.md:79: as it belongs to component more specific than Cr-Internals-Network. On 2016/03/09 21:39:09, Randy Smith - Not in Fridays wrote: > "as long as" -> "until"? Switched to "if the previous section still applies". https://codereview.chromium.org/1774733002/diff/60001/net/docs/bug-triage.md#... net/docs/bug-triage.md:111: that once it has at least a day of date. Recent releases available On 2016/03/09 21:39:09, Randy Smith - Not in Fridays wrote: > nit: "data". Done. https://codereview.chromium.org/1774733002/diff/60001/net/docs/bug-triage.md#... net/docs/bug-triage.md:116: than two users should be investigated. On 2016/03/09 21:39:09, Randy Smith - Not in Fridays wrote: > nit: Remove "should be investigated". Done.
The CQ bit was checked by mmenke@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rdsmith@chromium.org Link to the patchset: https://codereview.chromium.org/1774733002/#ps80001 (title: "Response to comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774733002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774733002/80001
Description was changed from ========== Update net docs. In particular, rework triage instructions, and clean up net-internals doc a little. BUG=none ========== to ========== Update net triage docs. In particular, rework triage instructions, and clean up net-internals doc a little. NOTRY=true BUG=none ==========
The CQ bit was checked by mmenke@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rdsmith@chromium.org Link to the patchset: https://codereview.chromium.org/1774733002/#ps100001 (title: "sort")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774733002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774733002/100001
Message was sent while issue was closed.
Description was changed from ========== Update net triage docs. In particular, rework triage instructions, and clean up net-internals doc a little. NOTRY=true BUG=none ========== to ========== Update net triage docs. In particular, rework triage instructions, and clean up net-internals doc a little. NOTRY=true BUG=none ==========
Message was sent while issue was closed.
Committed patchset #4 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Update net triage docs. In particular, rework triage instructions, and clean up net-internals doc a little. NOTRY=true BUG=none ========== to ========== Update net triage docs. In particular, rework triage instructions, and clean up net-internals doc a little. NOTRY=true BUG=none Committed: https://crrev.com/212fe432b87a4ee2aaaff40a55239b4740eb09e5 Cr-Commit-Position: refs/heads/master@{#380421} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/212fe432b87a4ee2aaaff40a55239b4740eb09e5 Cr-Commit-Position: refs/heads/master@{#380421} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
