Source/core/rendering/RenderBoxModelObject.cpp - Issue 177473003: Use SkLayerDrawLooper::Builder to construct SkLayerDrawLooper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBoxModelObject.cpp

Issue 177473003: Use SkLayerDrawLooper::Builder to construct SkLayerDrawLooper. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: DrawLooper::Builder Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/rendering/EllipsisBox.cpp ('K') | « Source/core/rendering/InlineTextBox.cpp ('k') | Source/core/rendering/svg/SVGInlineTextBox.cpp » ('j') | Source/platform/graphics/DrawLooper.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderBoxModelObject.cpp

diff --git a/Source/core/rendering/RenderBoxModelObject.cpp b/Source/core/rendering/RenderBoxModelObject.cpp

index bae01cbfebfa2248c829e08f2e9cd5a0a95509ad..bb9129f1de2bf767dfb1994614a101bb736ccffa 100644

--- a/Source/core/rendering/RenderBoxModelObject.cpp

+++ b/Source/core/rendering/RenderBoxModelObject.cpp

@@ -2512,10 +2512,10 @@ void RenderBoxModelObject::paintBoxShadow(const PaintInfo& info, const LayoutRec

}

// Draw only the shadow.

- DrawLooper drawLooper;

- drawLooper.addShadow(shadowOffset, shadowBlur, shadowColor,

+ DrawLooper::Builder drawLooperBuilder;

+ drawLooperBuilder.addShadow(shadowOffset, shadowBlur, shadowColor,

DrawLooper::ShadowRespectsTransforms, DrawLooper::ShadowIgnoresAlpha);

- context->setDrawLooper(drawLooper);

+ context->setDrawLooper(*drawLooperBuilder.detachDrawLooper().get());

if (hasBorderRadius) {

RoundedRect influenceRect(pixelSnappedIntRect(LayoutRect(shadowRect)), border.radii());