Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Side by Side Diff: Source/platform/graphics/DrawLooperBuilder.h

Issue 177473003: Use SkLayerDrawLooper::Builder to construct SkLayerDrawLooper. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove DrawLooper. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 10 matching lines...) Expand all
21 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 21 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
22 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 22 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef DrawLooper_h 31 #ifndef DrawLooperBuilder_h
32 #define DrawLooper_h 32 #define DrawLooperBuilder_h
33 33
34 #include "platform/PlatformExport.h" 34 #include "platform/PlatformExport.h"
35 #include "third_party/skia/include/effects/SkLayerDrawLooper.h"
35 #include "wtf/Noncopyable.h" 36 #include "wtf/Noncopyable.h"
36 #include "wtf/RefPtr.h" 37 #include "wtf/PassRefPtr.h"
37 38
38 class SkDrawLooper; 39 class SkDrawLooper;
39 class SkLayerDrawLooper;
40 40
41 namespace WebCore { 41 namespace WebCore {
42 42
43 class Color; 43 class Color;
44 class FloatSize; 44 class FloatSize;
45 45
46 class PLATFORM_EXPORT DrawLooper { 46 class PLATFORM_EXPORT DrawLooperBuilder {
Stephen Chennney 2014/02/26 19:35:18 Add "final" keyword to prevent inheritance. This i
Dominik Grewe 2014/02/27 12:15:09 Done.
47 // Implementing the copy constructor properly would require writing code to 47 // Implementing the copy constructor properly would require writing code to
48 // copy the underlying SkDrawLooper. 48 // copy the underlying SkLayerDrawLooper::Builder.
49 WTF_MAKE_NONCOPYABLE(DrawLooper); 49 WTF_MAKE_NONCOPYABLE(DrawLooperBuilder);
50 50
51 public: 51 public:
52 enum ShadowTransformMode { 52 enum ShadowTransformMode {
53 ShadowRespectsTransforms, 53 ShadowRespectsTransforms,
54 ShadowIgnoresTransforms 54 ShadowIgnoresTransforms
55 }; 55 };
56 enum ShadowAlphaMode { 56 enum ShadowAlphaMode {
57 ShadowRespectsAlpha, 57 ShadowRespectsAlpha,
58 ShadowIgnoresAlpha 58 ShadowIgnoresAlpha
59 }; 59 };
60 60
61 DrawLooper(); 61 DrawLooperBuilder();
62 ~DrawLooper(); 62 ~DrawLooperBuilder();
63 63
64 // Callees should not modify this looper other than to iterate over it. 64 // Creates the SkDrawLooper and passes ownership to the caller. The builder
65 // A downcast to SkLayerDrawLooper* is tantamount to a const_cast. 65 // should not be used any more after calling this method.
66 SkDrawLooper* skDrawLooper() const; 66 PassRefPtr<SkDrawLooper> detachDrawLooper();
67 67
68 void addUnmodifiedContent(); 68 void addUnmodifiedContent();
69 void addShadow(const FloatSize& offset, float blur, const Color&, 69 void addShadow(const FloatSize& offset, float blur, const Color&,
70 ShadowTransformMode = ShadowRespectsTransforms, 70 ShadowTransformMode = ShadowRespectsTransforms,
71 ShadowAlphaMode = ShadowRespectsAlpha); 71 ShadowAlphaMode = ShadowRespectsAlpha);
72 72
73 private: 73 private:
74 RefPtr<SkLayerDrawLooper> m_skDrawLooper; 74 SkLayerDrawLooper::Builder m_skDrawLooperBuilder;
75 }; 75 };
76 76
77 } // namespace WebCore 77 } // namespace WebCore
78 78
79 #endif // DrawLooper_h 79 #endif // DrawLooperBuilder_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698