Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1592)

Unified Diff: net/quic/quic_chromium_client_stream.cc

Issue 1774703003: QuicChromiumClientStream should only do OnStream after notifying delegate about trailers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_chromium_client_stream_test.cc » ('j') | net/quic/quic_spdy_stream.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_chromium_client_stream.cc
diff --git a/net/quic/quic_chromium_client_stream.cc b/net/quic/quic_chromium_client_stream.cc
index 50a3105b969cd882d041c40112759006daacc423..cdd513263c3cd1085e98524c8a250b9a92447117 100644
--- a/net/quic/quic_chromium_client_stream.cc
+++ b/net/quic/quic_chromium_client_stream.cc
@@ -58,12 +58,14 @@ void QuicChromiumClientStream::OnStreamHeadersComplete(bool fin,
if (!headers_delivered_) {
MarkHeadersConsumed(headers_len);
session_->OnInitialHeadersComplete(id(), headers);
+ // The delegate will read the headers via a posted task.
+ NotifyDelegateOfHeadersCompleteLater(headers, frame_len);
} else {
MarkTrailersConsumed(headers_len);
+ NotifyDelegateOfHeadersCompleteLater(headers, frame_len);
+ OnStreamFrame(
+ QuicStreamFrame(id(), fin, stream_bytes_read(), StringPiece()));
}
-
- // The delegate will read the headers via a posted task.
- NotifyDelegateOfHeadersCompleteLater(headers, frame_len);
}
void QuicChromiumClientStream::OnPromiseHeadersComplete(
« no previous file with comments | « no previous file | net/quic/quic_chromium_client_stream_test.cc » ('j') | net/quic/quic_spdy_stream.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698