Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: content/renderer/npapi/webplugin_impl.cc

Issue 1774653002: Decouple scheduling animation of webview plugins from layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/npapi/webplugin_impl.h" 5 #include "content/renderer/npapi/webplugin_impl.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/debug/crash_logging.h" 9 #include "base/debug/crash_logging.h"
10 #include "base/location.h" 10 #include "base/location.h"
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 bool WebPluginImpl::getFormValue(blink::WebString& value) { 160 bool WebPluginImpl::getFormValue(blink::WebString& value) {
161 if (!delegate_) 161 if (!delegate_)
162 return false; 162 return false;
163 base::string16 form_value; 163 base::string16 form_value;
164 if (!delegate_->GetFormValue(&form_value)) 164 if (!delegate_->GetFormValue(&form_value))
165 return false; 165 return false;
166 value = form_value; 166 value = form_value;
167 return true; 167 return true;
168 } 168 }
169 169
170 void WebPluginImpl::layoutIfNeeded() { 170 void WebPluginImpl::updateAllLifecyclePhases() {
171 if (!container_) 171 if (!container_)
172 return; 172 return;
173 173
174 #if defined(OS_WIN) 174 #if defined(OS_WIN)
175 // Force a geometry update if needed to allow plugins like media player 175 // Force a geometry update if needed to allow plugins like media player
176 // which defer the initial geometry update to work. Do it now, rather 176 // which defer the initial geometry update to work. Do it now, rather
177 // than in paint, so that the paint rect invalidation is registered. 177 // than in paint, so that the paint rect invalidation is registered.
178 // Otherwise we may never get the paint call. 178 // Otherwise we may never get the paint call.
179 container_->reportGeometry(); 179 container_->reportGeometry();
180 #endif // OS_WIN 180 #endif // OS_WIN
(...skipping 564 matching lines...) Expand 10 before | Expand all | Expand 10 after
745 case PLUGIN_SRC: 745 case PLUGIN_SRC:
746 webframe_->setReferrerForRequest(*request, plugin_url_); 746 webframe_->setReferrerForRequest(*request, plugin_url_);
747 break; 747 break;
748 748
749 default: 749 default:
750 break; 750 break;
751 } 751 }
752 } 752 }
753 753
754 } // namespace content 754 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698