Decouple scheduling animation of webview plugins from layout.

components/plugins/renderer/webview_plugin.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/plugins/renderer/webview_plugin.h"
 
 #include <stddef.h>
 
 #include "base/auto_reset.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 116 matching lines @@
 
 bool WebViewPlugin::initialize(WebPluginContainer* container) {
   container_ = container;
   if (container_) {
     // We must call layout again here to ensure that the container is laid
     // out before we next try to paint it, which is a requirement of the
     // document life cycle in Blink. In most cases, needsLayout is set by
     // scheduleAnimation, but due to timers controlling widget update,
     // scheduleAnimation may be invoked before this initialize call (which
     // comes through the widget update process). It doesn't hurt to mark
     // for layout again, and it does help us in the race-condition situation.

[Xianzhu, 2016/03/07 21:53:04]

Nit: does the above comment need update?

[chrishtr, 2016/03/07 22:23:43]

Updated layout to animation.

-    container_->setNeedsLayout();
+    container_->scheduleAnimation();
 
     old_title_ = container_->element().getAttribute("title");
 
     // Propagate device scale and zoom level to inner webview.
     web_view_->setDeviceScaleFactor(container_->deviceScaleFactor());
     web_view_->setZoomLevel(
         blink::WebView::zoomFactorToZoomLevel(container_->pageZoomFactor()));
   }
   return true;
 }
 
 void WebViewPlugin::destroy() {
   if (delegate_) {
     delegate_->PluginDestroyed();
     delegate_ = nullptr;
   }
   container_ = nullptr;
   content::RenderViewObserver::Observe(nullptr);
   base::MessageLoop::current()->DeleteSoon(FROM_HERE, this);
 }
 
 v8::Local<v8::Object> WebViewPlugin::v8ScriptableObject(v8::Isolate* isolate) {
   if (!delegate_)
     return v8::Local<v8::Object>();
 
   return delegate_->GetV8ScriptableObject(isolate);
 }
 
-// TODO(wkorman): Look into renaming this to something more in line with
-// either the Blink lifecycle or Compositor layer tree host nomenclature.
-void WebViewPlugin::layoutIfNeeded() {
+void WebViewPlugin::updateAllLifecyclePhases() {
   web_view_->updateAllLifecyclePhases();
 }
 
 void WebViewPlugin::paint(WebCanvas* canvas, const WebRect& rect) {
   gfx::Rect paint_rect = gfx::IntersectRects(rect_, rect);
   if (paint_rect.IsEmpty())
     return;
 
   base::AutoReset<bool> is_painting(
         &is_painting_, true);
@@ skipping 126 matching lines @@
   // be triggerd from within the WebView or this WebViewPlugin.
   // This is because this WebViewPlugin is contained in another
   // Web View which may be in the middle of updating its lifecycle,
   // but after layout is done, and it is illegal to dirty earlier
   // lifecycle stages during later ones.
   if (is_resizing_)
     return;
   if (container_) {
     // This should never happen; see also crbug.com/545039 for context.
     CHECK(!is_painting_);
-    container_->setNeedsLayout();
+    container_->scheduleAnimation();
   }
 }
 
 void WebViewPlugin::didClearWindowObject(WebLocalFrame* frame) {
   if (!delegate_)
     return;
 
   v8::Isolate* isolate = blink::mainThreadIsolate();
   v8::HandleScope handle_scope(isolate);
   v8::Local<v8::Context> context = frame->mainWorldScriptContext();
@@ skipping 15 matching lines @@
   // By default RenderViewObservers are destroyed along with the RenderView.
   // WebViewPlugin has a custom destruction mechanism, so we disable this.
 }
 
 void WebViewPlugin::OnZoomLevelChanged() {
   if (container_) {
     web_view_->setZoomLevel(
       blink::WebView::zoomFactorToZoomLevel(container_->pageZoomFactor()));
   }
 }