SkPDF Create working move constructor for inner classes

SkPDF Create working move constructor for inner classes

BUG=chromium:592330, chromium:592702
Committed: https://skia.googlesource.com/skia/+/d7b2885b90c6d248d8188cdb3720ea9150568a89

[hal.canary, 2016-03-07 20:21:28]

Description was changed from

==========
SkPDF Create working move constructor for inner classes
==========

to

==========
SkPDF Create working move constructor for inner classes
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[hal.canary, 2016-03-07 20:21:49]

halcanary@google.com changed reviewers:
+ bungeman@google.com

[hal.canary, 2016-03-07 20:21:49]

ptalk

[hal.canary, 2016-03-07 20:21:55]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-07 20:22:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774633002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774633002/1

[bungeman-skia, 2016-03-07 20:29:43]

Description was changed from

==========
SkPDF Create working move constructor for inner classes
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkPDF Create working move constructor for inner classes
==========

[hal.canary, 2016-03-07 20:35:11]

Description was changed from

==========
SkPDF Create working move constructor for inner classes
==========

to

==========
SkPDF Create working move constructor for inner classes

BUG=592330
BUG=592702
==========

[commit-bot: I haz the power, 2016-03-07 20:37:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-07 20:37:09]

Dry run: This issue passed the CQ dry run.

[bungeman-skia, 2016-03-07 20:37:11]

Description was changed from

==========
SkPDF Create working move constructor for inner classes

BUG=592330
BUG=592702
==========

to

==========
SkPDF Create working move constructor for inner classes

BUG=chromium:592330,chromium:592702
==========

[bungeman-skia, 2016-03-07 20:38:00]

The CQ bit was checked by bungeman@google.com

[bungeman-skia, 2016-03-07 20:38:01]

lgtm

[commit-bot: I haz the power, 2016-03-07 20:38:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774633002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774633002/1

[commit-bot: I haz the power, 2016-03-07 20:39:16]

Description was changed from

==========
SkPDF Create working move constructor for inner classes

BUG=chromium:592330,chromium:592702
==========

to

==========
SkPDF Create working move constructor for inner classes

BUG=chromium:592330,chromium:592702

Committed:
https://skia.googlesource.com/skia/+/d7b2885b90c6d248d8188cdb3720ea9150568a89
==========

[commit-bot: I haz the power, 2016-03-07 20:39:17]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d7b2885b90c6d248d8188cdb3720ea9150568a89

[reed1, 2016-03-07 20:47:41]

reed@google.com changed reviewers:
+ mtklein@google.com, reed@google.com

[reed1, 2016-03-07 20:47:42]

https://codereview.chromium.org/1774633002/diff/1/src/pdf/SkPDFDevice.h
File src/pdf/SkPDFDevice.h (right):

https://codereview.chromium.org/1774633002/diff/1/src/pdf/SkPDFDevice.h#newco...
src/pdf/SkPDFDevice.h:208: RectWithData(RectWithData&& other)
Seems like these are explicitly written (as opposed to just relying on what the
compiler will do for us) as a performance step for 1 bad compiler that will go
away soonish (e.g. windows 2013).

Perhaps we can simplify this code (and reviewing it) by just leaving these off,
and go slow on that windows compiler. I suggest that also since this data type
is hardly ever used (annotations) so we are not interested in paying more
complexity for speed (imho).