Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1774623005: [regexp] support \p in character classes. (Closed)

Created:
4 years, 9 months ago by Yang
Modified:
4 years, 8 months ago
Reviewers:
Dan Ehrenberg, PhistucK
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] support \p in character classes. R=littledan@chromium.org BUG=v8:4743 LOG=N Committed: https://crrev.com/aba76874dbf3f00741169ef763cdafe4d3600605 Cr-Commit-Position: refs/heads/master@{#34695}

Patch Set 1 #

Patch Set 2 : add test case #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -17 lines) Patch
M src/regexp/regexp-parser.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/regexp/regexp-parser.cc View 1 2 5 chunks +49 lines, -14 lines 0 comments Download
A test/mjsunit/harmony/regexp-property-char-class.js View 1 1 chunk +27 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/regexp-property-disabled.js View 1 chunk +18 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
Yang
Dan, please take a look.
4 years, 9 months ago (2016-03-09 12:40:51 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774623005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774623005/20001
4 years, 9 months ago (2016-03-09 13:04:38 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-09 13:24:10 UTC) #5
Yang
On 2016/03/09 13:24:10, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 9 months ago (2016-03-10 19:21:37 UTC) #6
Dan Ehrenberg
lgtm
4 years, 9 months ago (2016-03-10 19:35:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774623005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774623005/20001
4 years, 9 months ago (2016-03-10 19:43:17 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/14709) v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, ...
4 years, 9 months ago (2016-03-10 19:44:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774623005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774623005/40001
4 years, 9 months ago (2016-03-10 20:09:30 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-10 23:23:08 UTC) #15
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/aba76874dbf3f00741169ef763cdafe4d3600605 Cr-Commit-Position: refs/heads/master@{#34695}
4 years, 9 months ago (2016-03-10 23:24:29 UTC) #17
PhistucK
Why is it sometimes "property class" and sometimes "class property"? -ZoneList<CharacterRange>* RegExpParser::ParsePropertyClass() { +bool RegExpParser::ParsePropertyClass(ZoneList<CharacterRange>* ...
4 years, 9 months ago (2016-03-26 09:51:09 UTC) #19
Yang
4 years, 8 months ago (2016-03-30 05:04:08 UTC) #20
Message was sent while issue was closed.
On 2016/03/26 09:51:09, PhistucK wrote:
> Why is it sometimes "property class" and sometimes "class property"?
> -ZoneList<CharacterRange>* RegExpParser::ParsePropertyClass() {
> +bool RegExpParser::ParsePropertyClass(ZoneList<CharacterRange>* result) {
> ...
> +bool RegExpParser::ParseClassProperty(ZoneList<CharacterRange>* ranges) {

I realize that the naming might a bit confusing.
ParsePropertyClass is parsing a property class specified by \p.
ParseClassProperty is parsing a property class inside a character class, like
[\pL]. This is symmetrical to similar functions such as ParseClassAtom or
ParseClassCharacterEscape.

Powered by Google App Engine
This is Rietveld 408576698