[BackgroundSync] Remove RegistrationKey

[BackgroundSync] Remove RegistrationKey

Now that periodic syncs are out of the BackgroundSyncManager we no
longer need the RegistrationKey and can index registrations by tag.

BUG=592599
Committed: https://crrev.com/d065863ffa29ca63d569b6555a0e9697c90def8d
Cr-Commit-Position: refs/heads/master@{#381542}

[jkarlin, 2016-03-07 19:03:47]

jkarlin@chromium.org changed reviewers:
+ iclelland@chromium.org

[jkarlin, 2016-03-07 19:03:47]

iclelland@: PTAL, thanks!

[iclelland, 2016-03-08 16:53:15]

https://codereview.chromium.org/1774603002/diff/1/content/browser/background_...
File content/browser/background_sync/background_sync_manager.cc (left):

https://codereview.chromium.org/1774603002/diff/1/content/browser/background_...
content/browser/background_sync/background_sync_manager.cc:161: : value_("o_" +
tag) {
What affect will removing this have on previously scheduled syncs? Will we start
calling LookupActiveRegistration by tag, and not finding the registrations,
because they were originally stored with the prefix?

[jkarlin, 2016-03-08 17:25:58]

https://codereview.chromium.org/1774603002/diff/1/content/browser/background_...
File content/browser/background_sync/background_sync_manager.cc (left):

https://codereview.chromium.org/1774603002/diff/1/content/browser/background_...
content/browser/background_sync/background_sync_manager.cc:161: : value_("o_" +
tag) {
On 2016/03/08 16:53:15, iclelland wrote:
> What affect will removing this have on previously scheduled syncs? Will we
start
> calling LookupActiveRegistration by tag, and not finding the registrations,
> because they were originally stored with the prefix?

I'm not sure what I was thinking when I wrote that comment. The prefix is never
written to disk. It's just used as an in-memory index. So upgrading versions
should have no migration issues.

[iclelland, 2016-03-11 14:53:49]

On 2016/03/08 17:25:58, jkarlin wrote:
>
https://codereview.chromium.org/1774603002/diff/1/content/browser/background_...
> File content/browser/background_sync/background_sync_manager.cc (left):
> 
>
https://codereview.chromium.org/1774603002/diff/1/content/browser/background_...
> content/browser/background_sync/background_sync_manager.cc:161: : value_("o_"
+
> tag) {
> On 2016/03/08 16:53:15, iclelland wrote:
> > What affect will removing this have on previously scheduled syncs? Will we
> start
> > calling LookupActiveRegistration by tag, and not finding the registrations,
> > because they were originally stored with the prefix?
> 
> I'm not sure what I was thinking when I wrote that comment. The prefix is
never
> written to disk. It's just used as an in-memory index. So upgrading versions
> should have no migration issues.

Thanks; that makes sense. LGTM, then.

[jkarlin, 2016-03-16 19:57:19]

The CQ bit was checked by jkarlin@chromium.org

[jkarlin, 2016-03-16 19:57:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
iclelland@chromium.org
Link to the patchset: https://codereview.chromium.org/1774603002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-03-16 19:57:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774603002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774603002/60001

[commit-bot: I haz the power, 2016-03-16 21:05:37]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-16 21:06:55]

Description was changed from

==========
[BackgroundSync] Remove RegistrationKey

Now that periodic syncs are out of the BackgroundSyncManager we no
longer need the RegistrationKey and can index registrations by tag.

BUG=592599
==========

to

==========
[BackgroundSync] Remove RegistrationKey

Now that periodic syncs are out of the BackgroundSyncManager we no
longer need the RegistrationKey and can index registrations by tag.

BUG=592599

Committed: https://crrev.com/d065863ffa29ca63d569b6555a0e9697c90def8d
Cr-Commit-Position: refs/heads/master@{#381542}
==========

[commit-bot: I haz the power, 2016-03-16 21:06:57]

Patchset 4 (id:??) landed as
https://crrev.com/d065863ffa29ca63d569b6555a0e9697c90def8d
Cr-Commit-Position: refs/heads/master@{#381542}