make pm4f be RGBA always, not pmcolor order

src/core/SkPM4f.h

 /*
  * Copyright 2016 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkPM4f_DEFINED
 #define SkPM4f_DEFINED
 
 #include "SkColorPriv.h"
+#include "SkNx.h"
+
+static inline Sk4f swizzle_rb(const Sk4f& x) {
+    return Sk4f(x[2], x[1], x[0], x[3]);

[mtklein, 2016/03/07 18:01:14]

You're killing me...

    return SkNx_shuffle<2,1,0,3>(x);

+}
+
+static inline Sk4f swizzle_rgba_to_pmorder(const Sk4f& x) {
+#ifdef SK_PMCOLOR_IS_BGRA
+    return swizzle_rb(x);
+#else
+    return x;
+#endif
+}
+
+static inline Sk4f swizzle_pmorder_to_rgba(const Sk4f& x) {
+#ifdef SK_PMCOLOR_IS_BGRA
+    return swizzle_rb(x);
+#else
+    return x;
+#endif
+}
 
 /*
- *  The float values are 0...1 premultiplied
+ *  The float values are 0...1 premultiplied in RGBA order (regardless of SkPMColor order)
  */
 struct SkPM4f {
     enum {
-        A = SK_A32_SHIFT/8,
-        R = SK_R32_SHIFT/8,
-        G = SK_G32_SHIFT/8,
-        B = SK_B32_SHIFT/8,
+        R, G, B, A,
     };
     float fVec[4];
 
+    float r() const { return fVec[R]; }
+    float g() const { return fVec[G]; }
+    float b() const { return fVec[B]; }
     float a() const { return fVec[A]; }
 
+    static SkPM4f From4f(const Sk4f& x) {
+        SkPM4f pm;
+        x.store(pm.fVec);
+        return pm;
+    }
+    static SkPM4f FromF16(const uint16_t[4]);
+    static SkPM4f FromPMColor(SkPMColor);
+
+    Sk4f to4f() const { return Sk4f::Load(fVec); }

[mtklein, 2016/03/07 18:01:14]

Looks great to me now.  Thanks.

+    Sk4f to4f_rgba() const { return this->to4f(); }
+    Sk4f to4f_bgra() const { return swizzle_rb(this->to4f()); }
+    Sk4f to4f_pmorder() const { return swizzle_rgba_to_pmorder(this->to4f()); }
+
+    void toF16(uint16_t[4]) const;
+    uint64_t toF16() const; // 4 float16 values packed into uint64_t
+
     SkColor4f unpremul() const;
 
-    static SkPM4f FromPMColor(SkPMColor);
-
-    // half-float routines
-    void toF16(uint16_t[4]) const;
-    uint64_t toF16() const; // 4 float16 values packed into uint64_t
-    static SkPM4f FromF16(const uint16_t[4]);
-
 #ifdef SK_DEBUG
     void assertIsUnit() const;
 #else
     void assertIsUnit() const {}
 #endif
 };
 
 typedef SkPM4f (*SkXfermodeProc4f)(const SkPM4f& src, const SkPM4f& dst);
 
-
 #endif