third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js - Issue 1774503005: [DevTools] Roll closure compiler to ToT version

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

Issue 1774503005: [DevTools] Roll closure compiler to ToT version (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js ('K') | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineProfileTree.js ('k') | third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js » ('j') | third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

index 404a6b609e72902129996f947b101b2ae69ce30b..ff1ce375b5b936c06ca4e353858119f9dd0841cf 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

@@ -153,13 +153,16 @@ WebInspector.TimelineTreeView.prototype = {

/**

- * @param {!Array.<!WebInspector.DataGrid.ColumnDescriptor>} columns

+ * @param {!Array<!WebInspector.DataGrid.ColumnDescriptor>} columns

_populateColumns: function(columns)

{

- columns.push({id: "self", title: WebInspector.UIString("Self Time"), width: "110px", fixedWidth: true, sortable: true});

- columns.push({id: "total", title: WebInspector.UIString("Total Time"), width: "110px", fixedWidth: true, sortable: true});

- columns.push({id: "activity", title: WebInspector.UIString("Activity"), disclosure: true, sortable: true});

+ var columnDescriptors = [

+ {id: "self", title: WebInspector.UIString("Self Time"), width: "110px", fixedWidth: true, sortable: true},

+ {id: "total", title: WebInspector.UIString("Total Time"), width: "110px", fixedWidth: true, sortable: true},

+ {id: "activity", title: WebInspector.UIString("Activity"), disclosure: true, sortable: true}];

+ for (var descriptor of columnDescriptors)

+ columns.push(/** @type {!WebInspector.DataGrid.ColumnDescriptor} */(descriptor));

_sortingChanged: function()

@@ -898,7 +901,8 @@ WebInspector.EventsTimelineTreeView.prototype = {

_populateColumns: function(columns)

{

- columns.push({id: "startTime", title: WebInspector.UIString("Start Time"), width: "110px", fixedWidth: true, sortable: true});

+ var descriptors = [{id: "startTime", title: WebInspector.UIString("Start Time"), width: "110px", fixedWidth: true, sortable: true}];

+ columns.push(/** @type {!WebInspector.DataGrid.ColumnDescriptor} */(descriptors[0]));

WebInspector.TimelineTreeView.prototype._populateColumns.call(this, columns);