Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Unified Diff: platform_tools/android/bin/android_setup.sh

Issue 1774503004: Update android_make to support both --gcc and --clang options. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: better way to handle codec.gyp Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gyp/lua.gyp ('k') | platform_tools/android/bin/utils/setup_toolchain.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: platform_tools/android/bin/android_setup.sh
diff --git a/platform_tools/android/bin/android_setup.sh b/platform_tools/android/bin/android_setup.sh
index d9799c21bdc04d739bfb4164eb9de2de91b27162..3af118ef65f4c09f463abe26d0142d8431e490d0 100755
--- a/platform_tools/android/bin/android_setup.sh
+++ b/platform_tools/android/bin/android_setup.sh
@@ -12,6 +12,7 @@
set -e
BUILDTYPE=${BUILDTYPE-Debug}
+USE_CLANG="false"
while (( "$#" )); do
if [[ "$1" == "-d" ]]; then
@@ -29,9 +30,10 @@ while (( "$#" )); do
shift
elif [[ "$1" == "--release" ]]; then
BUILDTYPE=Release
+ elif [[ "$1" == "--gcc" ]]; then
+ USE_CLANG="false"
elif [[ "$1" == "--clang" ]]; then
- USE_CLANG="true"
- export GYP_DEFINES="skia_clang_build=1 $GYP_DEFINES"
+ USE_CLANG="true"
elif [[ "$1" == "--logcat" ]]; then
LOGCAT=1
elif [[ "$1" == "--verbose" ]]; then
@@ -42,6 +44,10 @@ while (( "$#" )); do
shift
done
+if [ "$USE_CLANG" == "true" ]; then
+ export GYP_DEFINES="skia_clang_build=1 $GYP_DEFINES"
+fi
+
function verbose {
if [[ -n $VERBOSE ]]; then
echo $@
« no previous file with comments | « gyp/lua.gyp ('k') | platform_tools/android/bin/utils/setup_toolchain.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698