Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1774503003: LayoutTests: prepare for V8 changes wrt var declaration break locations. (Closed)

Created:
4 years, 9 months ago by Yang
Modified:
4 years, 9 months ago
Reviewers:
Michael Achenbach
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

LayoutTests: prepare for V8 changes wrt var declaration break locations. R=machenbach@chromium.org BUG=chromium:592409 Committed: https://crrev.com/e23ec622747d4fc25e2989e36ef62709d9d707e6 Cr-Commit-Position: refs/heads/master@{#379542}

Patch Set 1 #

Total comments: 1

Patch Set 2 : use NeedsManualRebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/debugger/stepping-with-blackboxed-ranges-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Yang
4 years, 9 months ago (2016-03-07 11:41:04 UTC) #1
Michael Achenbach
lgtm https://codereview.chromium.org/1774503003/diff/1/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/1774503003/diff/1/third_party/WebKit/LayoutTests/TestExpectations#newcode1416 third_party/WebKit/LayoutTests/TestExpectations:1416: crbug.com/592409 inspector-protocol/debugger/stepping-with-blackboxed-ranges.html [ Failure Pass ] Why not ...
4 years, 9 months ago (2016-03-07 11:51:57 UTC) #2
Yang
On 2016/03/07 11:51:57, Michael Achenbach wrote: > lgtm > > https://codereview.chromium.org/1774503003/diff/1/third_party/WebKit/LayoutTests/TestExpectations > File third_party/WebKit/LayoutTests/TestExpectations (right): ...
4 years, 9 months ago (2016-03-07 11:55:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774503003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774503003/20001
4 years, 9 months ago (2016-03-07 11:56:00 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-07 12:54:23 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 12:55:46 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e23ec622747d4fc25e2989e36ef62709d9d707e6
Cr-Commit-Position: refs/heads/master@{#379542}

Powered by Google App Engine
This is Rietveld 408576698