about_flags.cc entry for WebRTC-H264WithOpenH264FFmpeg

about_flags.cc entry for WebRTC-H264WithOpenH264FFmpeg
(base::Feature kWebRtcH264WithOpenH264FFmpeg).

This is a feature that enables a H.264 encoder/decoder in
WebRTC. The feature is off by default.

This is a re-upload of
https://codereview.chromium.org/1722283002/. It was
reverted due to base/common.gypi depending on
../third_party/webrtc/build/common.gypi for rtc_use_h264.
In a webrtc standalone checkout, base/common.gypi is
processed such that this dependency does not get
resolved. Instead of finding a work-around where we can
get ahold of rtc_use_h264 in the base/common.gypi
context, I removed this use of it. This only affects the
generated_resources.grd file where rtc_use_h264 is not
used for the if. That means the two strings defined will
be included in the binary even when building without
h264 (the two strings will be unused).

BUG=chromium:500605, chromium:468365
Committed: https://crrev.com/18f5891498f7f1c90a7e1046bec1d933336db0a5
Cr-Commit-Position: refs/heads/master@{#379824}

[hbos_chromium, 2016-03-07 10:43:19]

Description was changed from

==========
about_flags.cc entry for WebRTC-H264WithOpenH264FFmpeg
(base::Feature kWebRtcH264WithOpenH264FFmpeg).

This is a feature that enables a H.264 encoder/decoder in
WebRTC. The feature is off by default.

This is a re-upload of
https://codereview.chromium.org/1722283002/.

BUG=chromium:500605, chromium:468365
==========

to

==========
about_flags.cc entry for WebRTC-H264WithOpenH264FFmpeg
(base::Feature kWebRtcH264WithOpenH264FFmpeg).

This is a feature that enables a H.264 encoder/decoder in
WebRTC. The feature is off by default.

This is a re-upload of
https://codereview.chromium.org/1722283002/. It was
reverted due to base/common.gypi depending on
../third_party/webrtc/build/common.gypi for rtc_use_h264.
In a webrtc standalone checkout, base/common.gypi is
processed such that this dependency does not get
resolved. Instead of finding a work-around where we can
get ahold of rtc_use_h264 in the base/common.gypi
context, I removed this use of it. This only affects the
generated_resources.grd file where rtc_use_h264 is not
used for the if. That means the two strings defined will be
included in the binary even though they're not used if
building with webrtc but without h264.

BUG=chromium:500605, chromium:468365
==========

[hbos_chromium, 2016-03-07 10:44:43]

Description was changed from

==========
about_flags.cc entry for WebRTC-H264WithOpenH264FFmpeg
(base::Feature kWebRtcH264WithOpenH264FFmpeg).

This is a feature that enables a H.264 encoder/decoder in
WebRTC. The feature is off by default.

This is a re-upload of
https://codereview.chromium.org/1722283002/. It was
reverted due to base/common.gypi depending on
../third_party/webrtc/build/common.gypi for rtc_use_h264.
In a webrtc standalone checkout, base/common.gypi is
processed such that this dependency does not get
resolved. Instead of finding a work-around where we can
get ahold of rtc_use_h264 in the base/common.gypi
context, I removed this use of it. This only affects the
generated_resources.grd file where rtc_use_h264 is not
used for the if. That means the two strings defined will be
included in the binary even though they're not used if
building with webrtc but without h264.

BUG=chromium:500605, chromium:468365
==========

to

==========
about_flags.cc entry for WebRTC-H264WithOpenH264FFmpeg
(base::Feature kWebRtcH264WithOpenH264FFmpeg).

This is a feature that enables a H.264 encoder/decoder in
WebRTC. The feature is off by default.

This is a re-upload of
https://codereview.chromium.org/1722283002/. It was
reverted due to base/common.gypi depending on
../third_party/webrtc/build/common.gypi for rtc_use_h264.
In a webrtc standalone checkout, base/common.gypi is
processed such that this dependency does not get
resolved. Instead of finding a work-around where we can
get ahold of rtc_use_h264 in the base/common.gypi
context, I removed this use of it. This only affects the
generated_resources.grd file where rtc_use_h264 is not
used for the if. That means the two strings defined will
be included in the binary even when building without
h264 (the two strings will be unused).

BUG=chromium:500605, chromium:468365
==========

[hbos_chromium, 2016-03-07 10:48:14]

hbos@chromium.org changed reviewers:
+ asvitkine@chromium.org, flackr@chromium.org, jochen@chromium.org,
rkaplow@chromium.org

[hbos_chromium, 2016-03-07 10:48:15]

Please take a look. Re-uploaded reverted CL and removed use of rtc_use_h264 for
the .grd file.

[jochen (gone - plz use gerrit), 2016-03-07 11:51:00]

lgtm

[rkaplow, 2016-03-07 22:14:45]

lgtm

[hbos_chromium, 2016-03-08 11:02:31]

PTAL asvitkine, flackr

[flackr, 2016-03-08 13:30:13]

lgtm

[Alexei Svitkine (slow), 2016-03-08 13:31:32]

lgtm

[hbos_chromium, 2016-03-08 13:32:15]

The CQ bit was checked by hbos@chromium.org

[commit-bot: I haz the power, 2016-03-08 13:32:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774483002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774483002/20001

[commit-bot: I haz the power, 2016-03-08 14:26:44]

Description was changed from

==========
about_flags.cc entry for WebRTC-H264WithOpenH264FFmpeg
(base::Feature kWebRtcH264WithOpenH264FFmpeg).

This is a feature that enables a H.264 encoder/decoder in
WebRTC. The feature is off by default.

This is a re-upload of
https://codereview.chromium.org/1722283002/. It was
reverted due to base/common.gypi depending on
../third_party/webrtc/build/common.gypi for rtc_use_h264.
In a webrtc standalone checkout, base/common.gypi is
processed such that this dependency does not get
resolved. Instead of finding a work-around where we can
get ahold of rtc_use_h264 in the base/common.gypi
context, I removed this use of it. This only affects the
generated_resources.grd file where rtc_use_h264 is not
used for the if. That means the two strings defined will
be included in the binary even when building without
h264 (the two strings will be unused).

BUG=chromium:500605, chromium:468365
==========

to

==========
about_flags.cc entry for WebRTC-H264WithOpenH264FFmpeg
(base::Feature kWebRtcH264WithOpenH264FFmpeg).

This is a feature that enables a H.264 encoder/decoder in
WebRTC. The feature is off by default.

This is a re-upload of
https://codereview.chromium.org/1722283002/. It was
reverted due to base/common.gypi depending on
../third_party/webrtc/build/common.gypi for rtc_use_h264.
In a webrtc standalone checkout, base/common.gypi is
processed such that this dependency does not get
resolved. Instead of finding a work-around where we can
get ahold of rtc_use_h264 in the base/common.gypi
context, I removed this use of it. This only affects the
generated_resources.grd file where rtc_use_h264 is not
used for the if. That means the two strings defined will
be included in the binary even when building without
h264 (the two strings will be unused).

BUG=chromium:500605, chromium:468365
==========

[commit-bot: I haz the power, 2016-03-08 14:26:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-08 14:28:00]

Description was changed from

==========
about_flags.cc entry for WebRTC-H264WithOpenH264FFmpeg
(base::Feature kWebRtcH264WithOpenH264FFmpeg).

This is a feature that enables a H.264 encoder/decoder in
WebRTC. The feature is off by default.

This is a re-upload of
https://codereview.chromium.org/1722283002/. It was
reverted due to base/common.gypi depending on
../third_party/webrtc/build/common.gypi for rtc_use_h264.
In a webrtc standalone checkout, base/common.gypi is
processed such that this dependency does not get
resolved. Instead of finding a work-around where we can
get ahold of rtc_use_h264 in the base/common.gypi
context, I removed this use of it. This only affects the
generated_resources.grd file where rtc_use_h264 is not
used for the if. That means the two strings defined will
be included in the binary even when building without
h264 (the two strings will be unused).

BUG=chromium:500605, chromium:468365
==========

to

==========
about_flags.cc entry for WebRTC-H264WithOpenH264FFmpeg
(base::Feature kWebRtcH264WithOpenH264FFmpeg).

This is a feature that enables a H.264 encoder/decoder in
WebRTC. The feature is off by default.

This is a re-upload of
https://codereview.chromium.org/1722283002/. It was
reverted due to base/common.gypi depending on
../third_party/webrtc/build/common.gypi for rtc_use_h264.
In a webrtc standalone checkout, base/common.gypi is
processed such that this dependency does not get
resolved. Instead of finding a work-around where we can
get ahold of rtc_use_h264 in the base/common.gypi
context, I removed this use of it. This only affects the
generated_resources.grd file where rtc_use_h264 is not
used for the if. That means the two strings defined will
be included in the binary even when building without
h264 (the two strings will be unused).

BUG=chromium:500605, chromium:468365

Committed: https://crrev.com/18f5891498f7f1c90a7e1046bec1d933336db0a5
Cr-Commit-Position: refs/heads/master@{#379824}
==========

[commit-bot: I haz the power, 2016-03-08 14:28:01]

Patchset 2 (id:??) landed as
https://crrev.com/18f5891498f7f1c90a7e1046bec1d933336db0a5
Cr-Commit-Position: refs/heads/master@{#379824}