Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1774463002: [wasm] Add a JavaScript utility to make it easier to build WASM modules from JavaScript. (Closed)

Created:
4 years, 9 months ago by titzer
Modified:
4 years, 9 months ago
Reviewers:
ahaas, binji, seththompson
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Add a JavaScript utility to make it easier to build WASM modules from JavaScript. This is a reland of https://codereview.chromium.org/1762203002/ R=ahaas@chromium.org,binji@chromium.org,seththompson@chromium.org BUG= Committed: https://crrev.com/aa5770805060a347c6b650634c736ba34ab61728 Cr-Commit-Position: refs/heads/master@{#34519}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+401 lines, -0 lines) Patch
A test/mjsunit/wasm/test-wasm-module-builder.js View 1 chunk +90 lines, -0 lines 0 comments Download
A test/mjsunit/wasm/wasm-module-builder.js View 1 chunk +311 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
titzer
4 years, 9 months ago (2016-03-07 08:49:12 UTC) #1
ahaas
lgtm
4 years, 9 months ago (2016-03-07 09:35:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774463002/1
4 years, 9 months ago (2016-03-07 09:43:36 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 09:45:53 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/aa5770805060a347c6b650634c736ba34ab61728 Cr-Commit-Position: refs/heads/master@{#34519}
4 years, 9 months ago (2016-03-07 09:46:47 UTC) #7
Michael Achenbach
4 years, 9 months ago (2016-03-07 09:59:59 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1768963002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Problem is not fixed:
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20shared/build....

Powered by Google App Engine
This is Rietveld 408576698