Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 177443006: [AudioPlayer] Add test for opening another file from Files.app (Closed)

Created:
6 years, 9 months ago by yoshiki
Modified:
6 years, 9 months ago
Reviewers:
hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

[AudioPlayer] Add test for opening another file from Files.app BUG=none TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255003

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rebase & addressed the comments #

Total comments: 2

Patch Set 3 : Adressed the comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -5 lines) Patch
M chrome/browser/resources/file_manager/background/js/test_util.js View 1 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_manager_browsertest/background.js View 1 2 2 chunks +36 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_manager_browsertest/open_special_types.js View 1 1 chunk +35 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
yoshiki
hirono, PTAL. Thanks.
6 years, 9 months ago (2014-03-04 09:06:47 UTC) #1
hirono
Could you rebase the patch to TOT? Thanks! https://codereview.chromium.org/177443006/diff/40001/chrome/browser/resources/file_manager/background/js/test_util.js File chrome/browser/resources/file_manager/background/js/test_util.js (right): https://codereview.chromium.org/177443006/diff/40001/chrome/browser/resources/file_manager/background/js/test_util.js#newcode114 chrome/browser/resources/file_manager/background/js/test_util.js:114: * ...
6 years, 9 months ago (2014-03-04 09:14:13 UTC) #2
yoshiki
hirono, PTAL. https://codereview.chromium.org/177443006/diff/40001/chrome/browser/resources/file_manager/background/js/test_util.js File chrome/browser/resources/file_manager/background/js/test_util.js (right): https://codereview.chromium.org/177443006/diff/40001/chrome/browser/resources/file_manager/background/js/test_util.js#newcode114 chrome/browser/resources/file_manager/background/js/test_util.js:114: * Close the specified window and wait ...
6 years, 9 months ago (2014-03-05 02:24:44 UTC) #3
hirono
Thanks, lgtm with a nit! https://codereview.chromium.org/177443006/diff/120001/chrome/test/data/extensions/api_test/file_manager_browsertest/background.js File chrome/test/data/extensions/api_test/file_manager_browsertest/background.js (right): https://codereview.chromium.org/177443006/diff/120001/chrome/test/data/extensions/api_test/file_manager_browsertest/background.js#newcode154 chrome/test/data/extensions/api_test/file_manager_browsertest/background.js:154: return pending('Window with the ...
6 years, 9 months ago (2014-03-05 03:55:13 UTC) #4
yoshiki
Thanks, going to commit, https://codereview.chromium.org/177443006/diff/120001/chrome/test/data/extensions/api_test/file_manager_browsertest/background.js File chrome/test/data/extensions/api_test/file_manager_browsertest/background.js (right): https://codereview.chromium.org/177443006/diff/120001/chrome/test/data/extensions/api_test/file_manager_browsertest/background.js#newcode154 chrome/test/data/extensions/api_test/file_manager_browsertest/background.js:154: return pending('Window with the prefix ...
6 years, 9 months ago (2014-03-05 04:23:01 UTC) #5
yoshiki
The CQ bit was checked by yoshiki@chromium.org
6 years, 9 months ago (2014-03-05 04:23:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/177443006/140001
6 years, 9 months ago (2014-03-05 04:24:32 UTC) #7
commit-bot: I haz the power
Change committed as 255003
6 years, 9 months ago (2014-03-05 10:30:04 UTC) #8
pkotwicz
6 years, 9 months ago (2014-03-06 01:16:46 UTC) #9
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/188253002/ by pkotwicz@chromium.org.

The reason for reverting is: This CL seems to be making
OpenSpecialTypes/FileManagerBrowserTest.Test/5 timeout. See:

http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20...

http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20....

Powered by Google App Engine
This is Rietveld 408576698