Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 1774423002: CrOS - in pre-MD mode, paint frame correctly (Closed)

Created:
4 years, 9 months ago by Evan Stade
Modified:
4 years, 9 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CrOS - in pre-MD mode, paint frame correctly This regressed in c26c0f3e2df970d98 which landed after the m50 branch, so this fix is mostly academic. But the change is small and if for some reason we need to revert to pre-MD on CrOS 51, this change will be necessary. BUG=592741 Committed: https://crrev.com/d4380cf09954439aa280f7bce3104eff1e53e526 Cr-Commit-Position: refs/heads/master@{#380318}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/browser/ui/views/frame/browser_non_client_frame_view.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Evan Stade
4 years, 9 months ago (2016-03-09 03:49:16 UTC) #2
Peter Kasting
LGTM
4 years, 9 months ago (2016-03-09 07:29:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774423002/1
4 years, 9 months ago (2016-03-09 22:07:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/137244)
4 years, 9 months ago (2016-03-09 22:41:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774423002/1
4 years, 9 months ago (2016-03-10 02:21:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 03:07:10 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 03:08:12 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d4380cf09954439aa280f7bce3104eff1e53e526
Cr-Commit-Position: refs/heads/master@{#380318}

Powered by Google App Engine
This is Rietveld 408576698