Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 1774413002: Revert of Convert the flaky SysCommand widget tests into interactive ui tests. (Closed)

Created:
4 years, 9 months ago by tsergeant
Modified:
4 years, 9 months ago
Reviewers:
ananta, sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Convert the flaky SysCommand widget tests into interactive ui tests. (patchset #1 id:1 of https://codereview.chromium.org/1776763002/ ) Reason for revert: The test WidgetTestInteractive.SysCommandMoveOnNCLButtonDownOnCaptionAndMoveTest is failing in interactive_ui_tests on Windows-7-SP1. See: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/46677 Original issue's description: > Convert the flaky SysCommand widget tests into interactive ui tests. > > It looks like these tests are flaky due to window messages not firing as expected. Hopefully > with these tests being converted to interactive ui tests we should not have flakiness due to activation > and related problems. > > Tests being converted are as below:- > 1. DestroyInSysCommandNCLButtonDownOnCaption > 2. SysCommandMoveOnNCLButtonDownOnCaptionAndMoveTest > > BUG=592742 > > Committed: https://crrev.com/da9b02d4f7b5c2ad53e6e0573edaf8f48c892ba3 > Cr-Commit-Position: refs/heads/master@{#379991} TBR=sky@chromium.org,ananta@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=592742 Committed: https://crrev.com/185cd4741f24c35ee5eba163195752cef5856db8 Cr-Commit-Position: refs/heads/master@{#380050}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -183 lines) Patch
M ui/views/widget/widget_interactive_uitest.cc View 1 chunk +0 lines, -183 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 chunk +187 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tsergeant
Created Revert of Convert the flaky SysCommand widget tests into interactive ui tests.
4 years, 9 months ago (2016-03-09 03:21:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774413002/1
4 years, 9 months ago (2016-03-09 03:21:52 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 03:22:16 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 03:23:36 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/185cd4741f24c35ee5eba163195752cef5856db8
Cr-Commit-Position: refs/heads/master@{#380050}

Powered by Google App Engine
This is Rietveld 408576698