Chromium Code Reviews
DescriptionRevert of Convert the flaky SysCommand widget tests into interactive ui tests. (patchset #1 id:1 of https://codereview.chromium.org/1776763002/ )
Reason for revert:
The test WidgetTestInteractive.SysCommandMoveOnNCLButtonDownOnCaptionAndMoveTest is failing in interactive_ui_tests on Windows-7-SP1. See:
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/46677
Original issue's description:
> Convert the flaky SysCommand widget tests into interactive ui tests.
>
> It looks like these tests are flaky due to window messages not firing as expected. Hopefully
> with these tests being converted to interactive ui tests we should not have flakiness due to activation
> and related problems.
>
> Tests being converted are as below:-
> 1. DestroyInSysCommandNCLButtonDownOnCaption
> 2. SysCommandMoveOnNCLButtonDownOnCaptionAndMoveTest
>
> BUG=592742
>
> Committed: https://crrev.com/da9b02d4f7b5c2ad53e6e0573edaf8f48c892ba3
> Cr-Commit-Position: refs/heads/master@{#379991}
TBR=sky@chromium.org,ananta@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=592742
Committed: https://crrev.com/185cd4741f24c35ee5eba163195752cef5856db8
Cr-Commit-Position: refs/heads/master@{#380050}
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|
||||||||||||||||||||||||||||