tests_lit/llvm2ice_tests/external_declaration.ll - Issue 1774383002: PNaCl Dynamic Linking: Force __pnacl_pso_root to be an external declaration.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tests_lit/llvm2ice_tests/external_declaration.ll

Issue 1774383002: PNaCl Dynamic Linking: Force __pnacl_pso_root to be an external declaration. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@fixes

Patch Set: Added test Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 ; RUN: %if --need=allow_dump --command %p2i -i %s --target=x8632 \
	Jim Stichnoth 2016/03/11 01:20:29 1. It would be nice to add a brief comment at the 1. It would be nice to add a brief comment at the top describing the purpose of the test file. Even if not all the other .ll tests do this... 2. It would probably be cleaner to remove the pnacl-sz flags that don't really matter: --target and -O2. Sean Klein 2016/03/11 01:27:45 Done. Show quoted text On 2016/03/11 01:20:29, stichnot wrote: > 1. It would be nice to add a brief comment at the top describing the purpose of > the test file. Even if not all the other .ll tests do this... > > 2. It would probably be cleaner to remove the pnacl-sz flags that don't really > matter: --target and -O2. Done.
	2 ; RUN --filetype=asm --args -O2 -nonsfi=0 \
	Jim Stichnoth 2016/03/11 01:20:29 s/RUN/RUN:/ otherwise these options are just ignor s/RUN/RUN:/ otherwise these options are just ignored :) Probably the default filetype is iasm and default nonsfi is 0, so this works accidentally. Sean Klein 2016/03/11 01:27:45 Yikes, my bad. Fixed. Show quoted text On 2016/03/11 01:20:29, stichnot wrote: > s/RUN/RUN:/ > otherwise these options are just ignored :) > > Probably the default filetype is iasm and default nonsfi is 0, so this works > accidentally. Yikes, my bad. Fixed.
	3 ; RUN: \| %if --need=allow_dump --command FileCheck %s

	4

	5 ; Verify that "__pnacl_pso_root", a specially named symbol, is made
	Jim Stichnoth 2016/03/11 01:20:29 reflow comment to 80-col reflow comment to 80-col Sean Klein 2016/03/11 01:27:45 Done. Show quoted text On 2016/03/11 01:20:29, stichnot wrote: > reflow comment to 80-col Done.
	6 ; global, but other global variables are not.

	7 @__pnacl_pso_root = constant [4 x i8] c"abcd";

	8 @__pnacl_pso_not_root = constant [4 x i8] c"efgh";

	9

	10 ; CHECK: .globl __pnacl_pso_root

	11 ; CHECK-NOT: .globl __pnacl_pso_not_root

OLD	NEW

« no previous file with comments | « src/PNaClTranslator.cpp ('k') | no next file » | no next file with comments »