Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 177433002: Rebase compressed-control-frame.html layout test (Closed)

Created:
6 years, 10 months ago by Adam Rice
Modified:
6 years, 9 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Rebase compressed-control-frame.html layout test The new implemention logs a different console message for this case. Updated the expectation accordingly. This CL requires Chromium CL https://codereview.chromium.org/177403002/ to be landed first. BUG=346211 TEST=compressed-control-frame.html layout test Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168304

Patch Set 1 #

Patch Set 2 : Update the console message to match https://codereview.chromium.org/177843015/ #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/websocket/compressed-control-frame-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Adam Rice
6 years, 9 months ago (2014-02-28 14:40:42 UTC) #1
tyoshino (SeeGerritForStatus)
lgtm
6 years, 9 months ago (2014-02-28 19:03:17 UTC) #2
Adam Rice
The CQ bit was checked by ricea@chromium.org
6 years, 9 months ago (2014-03-03 05:11:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ricea@chromium.org/177433002/50001
6 years, 9 months ago (2014-03-03 05:11:49 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 08:26:42 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=29852
6 years, 9 months ago (2014-03-03 08:26:42 UTC) #6
Adam Rice
The CQ bit was checked by ricea@chromium.org
6 years, 9 months ago (2014-03-03 08:51:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ricea@chromium.org/177433002/50001
6 years, 9 months ago (2014-03-03 08:52:11 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-03 12:51:23 UTC) #9
Message was sent while issue was closed.
Change committed as 168304

Powered by Google App Engine
This is Rietveld 408576698