Issue 17743003: [nacltoons] Roll cocos2dx + two bug fixes

Issue 17743003: [nacltoons] Roll cocos2dx + two bug fixes (Closed)

Created:
7 years, 6 months ago by Sam Clegg

Modified:
7 years, 6 months ago

Reviewers:
binji

CC:
native-client-reviews_googlegroups.com

Base URL:
https://nativeclient-sdk.googlecode.com/svn/trunk/src

Visibility:
Public.

More Reviews

Description

[nacltoons] Roll cocos2dx + two bug fixes Roll cocos2dx to the latest version. Also fix two bugs relating conversion from design space to screen space. BUG= R=binji@chromium.org Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1562

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -10 lines)			Patch
M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
M	nacltoons/Makefile	View		1 chunk	+1 line, -1 line	0 comments	Download
M	nacltoons/build/build-cocos2dx.sh	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	nacltoons/data/res/drawing.lua	View	1 2	3 chunks	+9 lines, -5 lines	0 comments	Download
M	nacltoons/data/res/util.lua	View		2 chunks	+11 lines, -3 lines	0 comments	Download
M	nacltoons/proj.linux/Makefile	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	nacltoons/proj.nacl/Makefile	View		1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

binji

lgtm https://codereview.chromium.org/17743003/diff/2001/nacltoons/data/res/drawing.lua File nacltoons/data/res/drawing.lua (right): https://codereview.chromium.org/17743003/diff/2001/nacltoons/data/res/drawing.lua#newcode62 nacltoons/data/res/drawing.lua:62: ccpoint = util.PointFromLua(luapoint) local ccpoint? https://codereview.chromium.org/17743003/diff/2001/nacltoons/data/res/drawing.lua#newcode63 nacltoons/data/res/drawing.lua:63: rtn ...

7 years, 6 months ago (2013-06-25 22:17:21 UTC) #2

Sam Clegg

https://codereview.chromium.org/17743003/diff/2001/nacltoons/data/res/drawing.lua File nacltoons/data/res/drawing.lua (right): https://codereview.chromium.org/17743003/diff/2001/nacltoons/data/res/drawing.lua#newcode62 nacltoons/data/res/drawing.lua:62: ccpoint = util.PointFromLua(luapoint) On 2013/06/25 22:17:21, binji wrote: > ...

7 years, 6 months ago (2013-06-26 00:01:25 UTC) #3

Sam Clegg

7 years, 6 months ago (2013-06-26 00:01:37 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r1562 (presubmit successful).

Expand Messages | Collapse Messages