Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1774283002: [MD settings] move footer class into dialog style-module (Closed)

Created:
4 years, 9 months ago by dschuyler
Modified:
4 years, 9 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] move footer class into dialog style-module This CL doesn't change the setting UI. It pulls (and adds) some dialog settings into the dialog style-module. This CL also changes some of the color settings to use polymer color variables. BUG=589630 Committed: https://crrev.com/784ec9cd1267be80e3e4f069f4c4674d49093700 Cr-Commit-Position: refs/heads/master@{#380172}

Patch Set 1 #

Patch Set 2 : merge with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -31 lines) Patch
D chrome/browser/resources/settings/reset_page/reset_profile_dialog.css View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/resources/settings/reset_page/reset_profile_dialog.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_dialog.html View 3 chunks +34 lines, -18 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
dschuyler
4 years, 9 months ago (2016-03-08 19:59:28 UTC) #2
dpapad
lgtm
4 years, 9 months ago (2016-03-08 20:05:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774283002/1
4 years, 9 months ago (2016-03-08 23:08:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/186013)
4 years, 9 months ago (2016-03-09 00:19:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774283002/20001
4 years, 9 months ago (2016-03-09 19:20:54 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-09 19:27:00 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 19:29:02 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/784ec9cd1267be80e3e4f069f4c4674d49093700
Cr-Commit-Position: refs/heads/master@{#380172}

Powered by Google App Engine
This is Rietveld 408576698