[undetectable] Really get comparisons of document.all right now.

[undetectable] Really get comparisons of document.all right now.

According to https://www.w3.org/TR/html5/obsolete.html#dom-document-all,
comparisons of document.all to other values such as strings or objects,
are unaffected. In fact document.all only gets special treatment in
comparisons with null or undefined according to HTML. Especially setting
the undetectable doesn't make two distinct JSReceivers equal.

R=jarin@chromium.org

Committed: https://crrev.com/679d9503cffe631cb3b938627274aea10893069c
Cr-Commit-Position: refs/heads/master@{#34608}

[Benedikt Meurer, 2016-03-08 19:55:10]

Hey Jaro,

Here's another attempt to finally get the document.all implementation more
correctish (the HTML spec doesn't really talk about multiple undetectable
objects, but it explicitly says that only null/undefined comparisons are
changed, which is what was implemented before we started doing this
kIsUndetectable bit on null/undefined map business).
Please take a look.

Thanks,
Benedikt

[Jarin, 2016-03-09 08:09:32]

lgtm

https://codereview.chromium.org/1774273002/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

https://codereview.chromium.org/1774273002/diff/1/src/arm/code-stubs-arm.cc#n...
src/arm/code-stubs-arm.cc:480: // Fast negative check for
internalized-to-internalized equality.
Please update the comment to describe what the function actually does.

[Benedikt Meurer, 2016-03-09 09:51:11]

https://codereview.chromium.org/1774273002/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

https://codereview.chromium.org/1774273002/diff/1/src/arm/code-stubs-arm.cc#n...
src/arm/code-stubs-arm.cc:480: // Fast negative check for
internalized-to-internalized equality.
On 2016/03/09 08:09:32, Jarin wrote:
> Please update the comment to describe what the function actually does.

Done.

[Benedikt Meurer, 2016-03-09 09:52:00]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-03-09 09:52:00]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/1774273002/#ps20001
(title: "Update comments.")

[commit-bot: I haz the power, 2016-03-09 09:52:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1774273002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1774273002/20001

[commit-bot: I haz the power, 2016-03-09 10:42:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-09 10:43:52]

Description was changed from

==========
[undetectable] Really get comparisons of document.all right now.

According to https://www.w3.org/TR/html5/obsolete.html#dom-document-all,
comparisons of document.all to other values such as strings or objects,
are unaffected. In fact document.all only gets special treatment in
comparisons with null or undefined according to HTML. Especially setting
the undetectable doesn't make two distinct JSReceivers equal.

R=jarin@chromium.org
==========

to

==========
[undetectable] Really get comparisons of document.all right now.

According to https://www.w3.org/TR/html5/obsolete.html#dom-document-all,
comparisons of document.all to other values such as strings or objects,
are unaffected. In fact document.all only gets special treatment in
comparisons with null or undefined according to HTML. Especially setting
the undetectable doesn't make two distinct JSReceivers equal.

R=jarin@chromium.org

Committed: https://crrev.com/679d9503cffe631cb3b938627274aea10893069c
Cr-Commit-Position: refs/heads/master@{#34608}
==========

[commit-bot: I haz the power, 2016-03-09 10:43:54]

Patchset 2 (id:??) landed as
https://crrev.com/679d9503cffe631cb3b938627274aea10893069c
Cr-Commit-Position: refs/heads/master@{#34608}