Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1774263002: Fix skiaserve in debug mode (Closed)

Created:
4 years, 9 months ago by joshua.litt
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M tools/skiaserve/skiaserve.cpp View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
joshualitt
ptal, the string 'localhost' seems to give us grief in debug skiaserve, and inet_pton fails.
4 years, 9 months ago (2016-03-08 19:25:23 UTC) #3
joshualitt
4 years, 9 months ago (2016-03-08 19:25:40 UTC) #5
jcgregorio
lgtm
4 years, 9 months ago (2016-03-08 20:22:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774263002/1
4 years, 9 months ago (2016-03-08 20:54:53 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 21:24:36 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b82f088a112d700db570b837ebbf1b2e3772077c

Powered by Google App Engine
This is Rietveld 408576698