Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 177423013: Add cull rect visualization to debugger (Closed)

Created:
6 years, 9 months ago by robertphillips
Modified:
6 years, 9 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

This adds cull rect visualization to the debugger's "mega" visualization mode. Committed: http://code.google.com/p/skia/source/detail?r=13649

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -29 lines) Patch
M src/utils/debugger/SkDebugCanvas.h View 2 chunks +13 lines, -1 line 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 4 chunks +25 lines, -14 lines 0 comments Download
M src/utils/debugger/SkDrawCommand.h View 6 chunks +26 lines, -13 lines 0 comments Download
M src/utils/debugger/SkDrawCommand.cpp View 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
robertphillips
6 years, 9 months ago (2014-03-03 21:41:57 UTC) #1
f(malita)
LGTM. If I grok this, it will show active cull rects for a given command ...
6 years, 9 months ago (2014-03-03 22:21:18 UTC) #2
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 9 months ago (2014-03-03 22:30:01 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 22:30:02 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 9 months ago (2014-03-03 22:30:02 UTC) #5
fmalita_google_do_not_use
On 2014/03/03 22:30:02, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 9 months ago (2014-03-03 22:30:39 UTC) #6
fmalita_google_do_not_use
The CQ bit was checked by fmalita@google.com
6 years, 9 months ago (2014-03-03 22:30:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/177423013/1
6 years, 9 months ago (2014-03-03 22:30:52 UTC) #8
robertphillips
That mode would be pretty easy to add - it would just entail making all ...
6 years, 9 months ago (2014-03-03 22:34:40 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-03 23:25:43 UTC) #10
Message was sent while issue was closed.
Change committed as 13649

Powered by Google App Engine
This is Rietveld 408576698