Issue 177423011: Remove MediaControlVolumeSliderElement::m_clearMutedOnUserInteraction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 177423011: Remove MediaControlVolumeSliderElement::m_clearMutedOnUserInteraction (Closed)

Created:
6 years, 9 months ago by philipj_slow

Modified:
6 years, 9 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove MediaControlVolumeSliderElement::m_clearMutedOnUserInteraction It is always set to true. Also drop the volume change check, since HTMLMediaElement::setVolume() and MediaController::setVolume() already do that. BUG=341813 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168438

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -15 lines)			Patch
M	Source/core/html/shadow/MediaControlElementTypes.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	Source/core/html/shadow/MediaControlElementTypes.cpp	View	3 chunks	+2 lines, -10 lines	0 comments	Download
M	Source/core/html/shadow/MediaControls.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/177423011/1

6 years, 9 months ago (2014-03-04 02:45:43 UTC) #4

Message was sent while issue was closed.

Change committed as 168438

Expand Messages | Collapse Messages