Issue 177423009: [Android WebView] Provide a response header for application-provided content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 177423009: [Android WebView] Provide a response header for application-provided content (Closed)

Created:
6 years, 9 months ago by mnaganov (inactive)

Modified:
6 years, 9 months ago

Reviewers:
mkosiba (inactive)

CC:
chromium-reviews, cbentzel+watch_chromium.org, android-webview-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android WebView] Provide a response header for application-provided content Add "Client-Via: shouldInterceptRequest" header to responses created for the content provided by the embedder via WebViewClient.shouldInterceptRequest. This helps easily identifying application-provided responses in DevTools Network tab. BUG=347503 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253836

Patch Set 1 #

Patch Set 2 : Added test #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -0 lines)			Patch
	M	android_webview/browser/net/android_stream_reader_url_request_job.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download
	M	android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java	View	1	1 chunk	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

mnaganov (inactive)

I'll add a test soon. Please let me know, if you are OK with the ...

6 years, 9 months ago (2014-02-27 11:14:43 UTC) #1

mnaganov (inactive)

The CQ bit was checked by mnaganov@chromium.org

6 years, 9 months ago (2014-02-27 13:02:26 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/177423009/20001

6 years, 9 months ago (2014-02-27 13:05:06 UTC) #4

Message was sent while issue was closed.

Change committed as 253836

Expand Messages | Collapse Messages