Issue 1774213003: Fix `enableConditionalDirectives` option handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1774213003: Fix `enableConditionalDirectives` option handling. (Closed)

Created:
4 years, 9 months ago by pquitslund

Modified:
4 years, 9 months ago

Reviewers:
Brian Wilkerson, jackson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix `enableConditionalDirectives` option handling. Net-net: we weren't copying this value over when copying context options. BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/402f27e26df90e86e19ef2d9d6301a1c54016771

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	pkg/analysis_server/test/context_manager_test.dart	View		2 chunks	+3 lines, -0 lines	0 comments	Download
	M	pkg/analyzer/lib/src/generated/engine.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 7 (3 generated)

pquitslund

4 years, 9 months ago (2016-03-09 18:01:32 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
402f27e26df90e86e19ef2d9d6301a1c54016771 (presubmit successful).