Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1774193004: Fix (at least some) of Android Swarming /w GN (Closed)

Created:
4 years, 9 months ago by agrieve
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke, jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix (at least some) of Android Swarming /w GN Verified this fixes android_webview_unittests BUG=589318 Committed: https://crrev.com/5e338bf5ab3fb1cd818f10e665c4d76964aac158 Cr-Commit-Position: refs/heads/master@{#380183}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
agrieve
On 2016/03/09 19:04:26, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:jbudorick@chromium.org 🗽
4 years, 9 months ago (2016-03-09 19:04:40 UTC) #3
jbudorick
On 2016/03/09 19:04:40, agrieve wrote: > On 2016/03/09 19:04:26, agrieve wrote: > > mailto:agrieve@chromium.org changed ...
4 years, 9 months ago (2016-03-09 19:06:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774193004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774193004/1
4 years, 9 months ago (2016-03-09 19:08:05 UTC) #6
Dirk Pranke
lgtm
4 years, 9 months ago (2016-03-09 19:35:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 20:03:20 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 20:07:42 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e338bf5ab3fb1cd818f10e665c4d76964aac158
Cr-Commit-Position: refs/heads/master@{#380183}

Powered by Google App Engine
This is Rietveld 408576698