third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp - Issue 1774193002: New paint invalidation using paint property tree walk

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp

Issue 1774193002: New paint invalidation using paint property tree walk (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.cpp ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp » ('j') | third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp

index 7c8d826e75e5b4509eb08ece2204b9a2f15acaa0..e2f907764e3e41020fa1a3e9ed45ee2afb6661ba 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp

@@ -235,7 +235,8 @@ LayoutRect LayoutSVGInlineText::clippedOverflowRectForPaintInvalidation(const La

{

// FIXME: The following works because LayoutSVGBlock has forced slow rect mapping of the paintInvalidationState.

// Should let this really work with paintInvalidationState's fast mapping and remove the assert.

- ASSERT(!paintInvalidationState || !paintInvalidationState->canMapToContainer(paintInvalidationContainer));

+ // TODO(wangxianzhu): Check if we should re-enable or change this assert for slimmingPaintInvalidation.

+ ASSERT(RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled() || !paintInvalidationState || !paintInvalidationState->canMapToContainer(paintInvalidationContainer));

return parent()->clippedOverflowRectForPaintInvalidation(paintInvalidationContainer, paintInvalidationState);

}