third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.cpp - Issue 1774193002: New paint invalidation using paint property tree walk

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.cpp

Issue 1774193002: New paint invalidation using paint property tree walk (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/PaintInvalidationState.h ('K') | « third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp » ('j') | third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.cpp

index 1d87a97520bda31e3004c75d263ef9eaf8c40b50..8f66232194937e5e55301a023cb9d891e77baa74 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.cpp

@@ -150,6 +150,7 @@ void LayoutSVGInline::removeChild(LayoutObject* child)

void LayoutSVGInline::invalidateTreeIfNeeded(PaintInvalidationState& paintInvalidationState)

{

+ ASSERT(!RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled());

chrishtr 2016/03/11 21:30:00 Why?

Xianzhu 2016/03/11 22:01:47 Now we walk the tree in PrePaintTreeWalk in place

ASSERT(!needsLayout());

if (!shouldCheckForPaintInvalidation(paintInvalidationState))