third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 1774193002: New paint invalidation using paint property tree walk

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 1774193002: New paint invalidation using paint property tree walk (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Correct tracking of paintInvalidationContainer Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp » ('j') | third_party/WebKit/Source/core/layout/PaintInvalidationState.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index c48220c9b982670f937e3d025d61a06373815254..3b3a834853a9a65341493099f3c97bff0c64ef50 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -3822,12 +3822,6 @@ PaintInvalidationReason LayoutBox::getPaintInvalidationReason(const LayoutBoxMod

if (oldBorderBoxSize == newBorderBoxSize)

return invalidationReason;

- // LayoutBox::incrementallyInvalidatePaint() depends on positionFromPaintInvalidationBacking

- // which is not available when slimmingPaintOffsetCachingEnabled.

- if (RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled() && (style()->hasBoxDecorations() || style()->hasBackground()))

- return PaintInvalidationBorderBoxChange;

- // TODO(wangxianzhu): Remove incremental invalidation when we remove rect-based paint invalidation.

// See another hasNonCompositedScrollbars() callsite above.

if (hasNonCompositedScrollbars())

return PaintInvalidationBorderBoxChange;