New paint invalidation using paint property tree walk

third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PaintPropertyTreeBuilder_h
 #define PaintPropertyTreeBuilder_h
 
+#include "wtf/Vector.h"
+
 namespace blink {
 
 class FrameView;
 class LayoutObject;
+class PaintInvalidationState;
 struct PaintPropertyTreeBuilderContext;
 
 // This class walks the whole layout tree, beginning from the root FrameView, across
 // frame boundaries. The walk will collect special things in the layout tree and create
 // paint property nodes for them. Special things include but not limit to: overflow clip,
 // transform, fixed-pos, animation, mask, filter, ... etc.
 // It expects to be invoked after layout clean, i.e. during InPaintPropertyUpdate phase.
 class PaintPropertyTreeBuilder {
 public:
     void buildPropertyTrees(FrameView& rootFrame);
 
+    const Vector<LayoutObject*>& pendingDelayedPaintInvalidations() const { return m_pendingDelayedPaintInvalidations; }

[pdr., 2016/03/11 02:56:41]

Does this need to be public or can it be done as the last step in
buildPropertyTrees?

We should also rename buildPropertyTrees or add a second function called
buildPropertyTreesAndInvalidatePaint

[Xianzhu, 2016/03/11 20:03:45]

We need to handle the delayed invalidations after document lifecycle is advanced
to UpdatePaintPropertiesClean to ensure we'll schedule a visual update for the
delayed paint invalidations.
Done.

+
 private:

[pdr., 2016/03/11 02:56:41]

This class will form the basis of all our paint work for a quarter or more so we
should be careful not to confuse folks outside the paint team. Because
PaintPropertyTreeBuilder now does one or two things, what do you think about
giving it a more ambiguous name like PrePaintTreeWalk.cpp?

@chrishtr may have thoughts too.

With or without my name suggestion, please update the comment at the top of this
file. Something like so:
// This class walks layout&frame trees in primary tree order (think DOM order),
// beginning from the root FrameView and crossing local frame boundaries. The
// walk is used to create property tree nodes for layout & frame properties such
// as clips and transforms. It should be invoked after layout, during
// InPaintPropertyUpdate.
//
// If "slimmingPaintInvalidation", we also invalidate paint along the way.
// [maybe some more detail here]

[Xianzhu, 2016/03/11 20:03:45]

PrePaintTreeWalk sgtm. chrishtr wdyt?
Done.

[chrishtr, 2016/03/11 21:30:00]

SGTM

-    void walk(FrameView&, const PaintPropertyTreeBuilderContext&);
-    void walk(LayoutObject&, const PaintPropertyTreeBuilderContext&);
+    void walk(FrameView&, const PaintPropertyTreeBuilderContext&, const PaintInvalidationState*);
+    void walk(const LayoutObject&, const PaintPropertyTreeBuilderContext&, const PaintInvalidationState*);
+
+    Vector<LayoutObject*> m_pendingDelayedPaintInvalidations;

[pdr., 2016/03/11 02:56:41]

Can you add a comment above this? Something like so:
// Objects requiring invalidation after this phase of paint invalidation. See
the definition of PaintInvalidationDelayedFull for more detail.

[Xianzhu, 2016/03/11 20:03:45]

Done.

 };
 
 } // namespace blink
 
 #endif // PaintPropertyTreeBuilder_h