Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 1774133002: docs: copy the mac wording for installing api-keys over to ios instructions (Closed)

Created:
4 years, 9 months ago by tfarina
Modified:
4 years, 9 months ago
Reviewers:
sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

docs: copy the mac wording for installing api-keys over to ios instructions The current wording says you 'should' install to build, but that is not really true if you don't want to test some Google services and 'should' sounds very strong. The Mac version has nicer wording for directing users to install the API keys if they want so we ported it over here. BUG=None R=sdefresne@chromium.org Committed: https://crrev.com/b7c6e4eb7933958a2d273fe58b3e0da05885a006 Cr-Commit-Position: refs/heads/master@{#379885}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M docs/ios_build_instructions.md View 1 chunk +4 lines, -2 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
tfarina
https://codereview.chromium.org/1774133002/diff/1/docs/ios_build_instructions.md File docs/ios_build_instructions.md (right): https://codereview.chromium.org/1774133002/diff/1/docs/ios_build_instructions.md#newcode44 docs/ios_build_instructions.md:44: Before you build, you may want to Is this ...
4 years, 9 months ago (2016-03-08 14:58:14 UTC) #1
sdefresne
lgtm
4 years, 9 months ago (2016-03-08 15:21:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774133002/1
4 years, 9 months ago (2016-03-08 19:23:29 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 19:28:42 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 19:30:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7c6e4eb7933958a2d273fe58b3e0da05885a006
Cr-Commit-Position: refs/heads/master@{#379885}

Powered by Google App Engine
This is Rietveld 408576698