Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 177413009: Oilpan: Don't trace the RefPtr for the CSSCursorImageValue workaround. It is trace via the RefCount… (Closed)

Created:
6 years, 9 months ago by Mads Ager (chromium)
Modified:
6 years, 9 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Visibility:
Public.

Description

Oilpan: Don't trace the RefPtr for the CSSCursorImageValue workaround. It is trace via the RefCountedGarbageCollected persistent. We are correctly hitting an UNREACHABLE when tracing a RefPtr with enable_oilpan=1 on the bots. R=haraken@chromium.org, wibling@chromium.org, oilpan-reviews@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168459

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/core/css/CSSCursorImageValue.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Mads Ager (chromium)
6 years, 9 months ago (2014-03-05 08:21:41 UTC) #1
wibling-chromium
lgtm
6 years, 9 months ago (2014-03-05 08:22:18 UTC) #2
haraken
LGTM
6 years, 9 months ago (2014-03-05 08:22:54 UTC) #3
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 9 months ago (2014-03-05 08:27:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/177413009/1
6 years, 9 months ago (2014-03-05 08:28:38 UTC) #5
Mads Ager (chromium)
The CQ bit was unchecked by ager@chromium.org
6 years, 9 months ago (2014-03-05 09:51:48 UTC) #6
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 9 months ago (2014-03-05 09:52:02 UTC) #7
Mads Ager (chromium)
The CQ bit was unchecked by ager@chromium.org
6 years, 9 months ago (2014-03-05 10:00:42 UTC) #8
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 9 months ago (2014-03-05 10:06:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/177413009/1
6 years, 9 months ago (2014-03-05 10:07:19 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 10:07:37 UTC) #11
Message was sent while issue was closed. 
Change committed as 168459

Powered by Google App Engine
This is Rietveld 408576698