Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 177413006: Fix VPrintHelper used on Windows. (Closed)

Created:
6 years, 10 months ago by Vyacheslav Egorov (Chromium)
Modified:
6 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Fix VPrintHelper used on Windows. VPrintHelper would silently ignore the stream given to it if application is in GUI mode (no console is attached) and redirect output to the debugger via OutputDebugString. Such redirection makes sense only if passed stream is either stderr or stdout. Don't redirect any other stream to the debugger. Reorder clauses in VPrintHelper to make condition more readable. BUG= R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19688

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/platform-win32.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Chromium)
Please take a look. This fixes --redirect-code-traces on Windows when used from inside the Chrome. ...
6 years, 10 months ago (2014-02-24 19:24:25 UTC) #1
Yang
On 2014/02/24 19:24:25, Vyacheslav Egorov wrote: > Please take a look. > > This fixes ...
6 years, 10 months ago (2014-02-25 15:26:29 UTC) #2
Vyacheslav Egorov (Chromium)
6 years, 9 months ago (2014-03-06 11:55:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19688 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698