Support clang-cl build on Windows.

Support clang-cl build on Windows.

R=thakis@chromium.org, tsepez@chromium.org
BUG=

Committed: https://pdfium.googlesource.com/pdfium/+/2f4232d5b7e0c99b809b67d9ee30aaff3a7d84a5

[Oliver Chang, 2016-03-09 01:33:13]

Tom, for review.

Sorry for the delay in getting this done. I blame perf.

[Oliver Chang, 2016-03-09 01:33:41]

also, XFA doesn't build cleanly yet (but non XFA does). Will address in another
CL.

[Oliver Chang, 2016-03-09 01:35:43]

Description was changed from

==========
Support clang-cl build on Windows.

R=tsepez@chromium.org
BUG=
==========

to

==========
Support clang-cl build on Windows.

R=tsepez@chromium.org
BUG=
==========

[Oliver Chang, 2016-03-09 01:35:44]

ochang@chromium.org changed reviewers:
+ thakis@chromium.org

[Oliver Chang, 2016-03-09 01:35:49]

+Nico.

[Nico, 2016-03-09 02:30:19]

lgtm. gyp-only, no gn intentionally for now, i assume.

https://codereview.chromium.org/1774123005/diff/1/testing/gtest.gyp
File testing/gtest.gyp (right):

https://codereview.chromium.org/1774123005/diff/1/testing/gtest.gyp#newcode148
testing/gtest.gyp:148: '-Wno-unused'
We only need the first of these two in chromium's src/testing/gtest.gyp, and the
first one has a nice comment there

https://codereview.chromium.org/1774123005/diff/1/third_party/third_party.gyp
File third_party/third_party.gyp (right):

https://codereview.chromium.org/1774123005/diff/1/third_party/third_party.gyp...
third_party/third_party.gyp:244: '-Wno-shift-negative-value',
can you add a comment describing why this is needed?

https://codereview.chromium.org/1774123005/diff/1/third_party/third_party.gyp...
third_party/third_party.gyp:332: '-Wno-shift-negative-value',
likewise

[Oliver Chang, 2016-03-09 17:00:18]

Thanks for reviewing.

Yeah, we don't support standalone GN builds yet.

https://codereview.chromium.org/1774123005/diff/1/testing/gtest.gyp
File testing/gtest.gyp (right):

https://codereview.chromium.org/1774123005/diff/1/testing/gtest.gyp#newcode148
testing/gtest.gyp:148: '-Wno-unused'
On 2016/03/09 02:30:19, Nico wrote:
> We only need the first of these two in chromium's src/testing/gtest.gyp, and
the
> first one has a nice comment there

Added comments.

We need both here for some reason. Perhaps the version of gtest here is
different?

https://codereview.chromium.org/1774123005/diff/1/third_party/third_party.gyp
File third_party/third_party.gyp (right):

https://codereview.chromium.org/1774123005/diff/1/third_party/third_party.gyp...
third_party/third_party.gyp:244: '-Wno-shift-negative-value',
On 2016/03/09 02:30:19, Nico wrote:
> can you add a comment describing why this is needed?

Done.

https://codereview.chromium.org/1774123005/diff/1/third_party/third_party.gyp...
third_party/third_party.gyp:332: '-Wno-shift-negative-value',
On 2016/03/09 02:30:19, Nico wrote:
> likewise

Done.

[Oliver Chang, 2016-03-09 17:11:53]

Description was changed from

==========
Support clang-cl build on Windows.

R=tsepez@chromium.org
BUG=
==========

to

==========
Support clang-cl build on Windows.

R=thakis@chromium.org, tsepez@chromium.org
BUG=

Committed:
https://pdfium.googlesource.com/pdfium/+/2f4232d5b7e0c99b809b67d9ee30aaff3a7d...
==========

[Oliver Chang, 2016-03-09 17:11:55]

Committed patchset #2 (id:20001) manually as
2f4232d5b7e0c99b809b67d9ee30aaff3a7d84a5 (presubmit successful).