Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1774103002: Cleanup: remove evil hack to suppress permission warnings for searchProvider (Closed)

Created:
4 years, 9 months ago by Marc Treib
Modified:
4 years, 9 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: remove evil hack to suppress permission warnings for searchProvider BUG=533086 Committed: https://crrev.com/3e7756c7d39828136744fe7dffe1104eb5433843 Cr-Commit-Position: refs/heads/master@{#379840}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -57 lines) Patch
M chrome/common/extensions/permissions/chrome_permission_message_provider.cc View 2 chunks +0 lines, -23 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_permission_message_provider_unittest.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M extensions/common/permissions/settings_override_permission.cc View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Marc Treib
Hi Devlin, PTAL - should be safe to remove this now! :)
4 years, 9 months ago (2016-03-08 11:32:08 UTC) #2
Devlin
Yay! LGTM
4 years, 9 months ago (2016-03-08 15:15:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774103002/1
4 years, 9 months ago (2016-03-08 15:15:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/61018)
4 years, 9 months ago (2016-03-08 15:26:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774103002/1
4 years, 9 months ago (2016-03-08 15:27:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/32953)
4 years, 9 months ago (2016-03-08 15:33:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1774103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1774103002/1
4 years, 9 months ago (2016-03-08 16:11:43 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 16:30:21 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3e7756c7d39828136744fe7dffe1104eb5433843 Cr-Commit-Position: refs/heads/master@{#379840}
4 years, 9 months ago (2016-03-08 16:31:27 UTC) #16
Marc Treib
4 years, 6 months ago (2016-06-17 09:31:19 UTC) #17
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2071293002/ by treib@chromium.org.

The reason for reverting is: crbug.com/619759.

Powered by Google App Engine
This is Rietveld 408576698