net::WebSocketChannel should reject reserved bits

net::WebSocketChannel should reject reserved bits

Check the RSV1, RSV2 and RSV3 bits in WebSocketChannel::HandleFrame and
fail the connection if they are set.

Document the requirement for extensions to clear the bits when validly
set in WebSocketStream.

BUG=346211
TEST=net_unittests, compressed-control-frame.html layout test

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253423

[yhirano, 2014-02-25 07:16:00]

lgtm

https://codereview.chromium.org/177403002/diff/1/net/websockets/websocket_str...
File net/websockets/websocket_stream.h (right):

https://codereview.chromium.org/177403002/diff/1/net/websockets/websocket_str...
net/websockets/websocket_stream.h:138: // Extensions which use reserved header
bits should clear them when they are
"when they are are set correctly?"

[Adam Rice, 2014-02-25 07:35:39]

+tyoshino for OWNERS

[tyoshino (SeeGerritForStatus), 2014-02-25 07:41:42]

lgtm

[Adam Rice, 2014-02-25 08:07:13]

The CQ bit was checked by ricea@chromium.org

[commit-bot: I haz the power, 2014-02-25 08:08:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ricea@chromium.org/177403002/40001

[commit-bot: I haz the power, 2014-02-25 09:17:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ricea@chromium.org/177403002/40001

[commit-bot: I haz the power, 2014-02-25 09:37:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ricea@chromium.org/177403002/40001

[commit-bot: I haz the power, 2014-02-25 11:09:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-25 11:09:19]

Try jobs failed on following builders: mac_chromium_rel

[Adam Rice, 2014-02-26 07:15:40]

The CQ bit was checked by ricea@chromium.org

[commit-bot: I haz the power, 2014-02-26 07:21:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ricea@chromium.org/177403002/40001

[commit-bot: I haz the power, 2014-02-26 13:11:40]

Change committed as 253423